Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 417483002: Drop the 'WebURLRequest::TargetType' enum. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Project:
blink
Visibility:
Public.

Description

Drop the 'WebURLRequest::TargetType' enum. We no longer use this enum in Chromium; everything has been ported over to using '::RequestContext' and '::FrameType', so we can safely remove both the enum and the translation machinery in '::setTargetType'. BUG=390497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -195 lines) Patch
M Source/platform/exported/WebURLRequest.cpp View 1 chunk +0 lines, -164 lines 0 comments Download
M public/platform/WebURLRequest.h View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Once those other three Chromium-side patches land, this patch will compile. WDYT, Jochen? -mike
6 years, 5 months ago (2014-07-23 09:39:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 09:46:48 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-29 10:10:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/417483002/1
6 years, 4 months ago (2014-07-29 10:11:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 11:24:21 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 11:42:55 UTC) #6
Message was sent while issue was closed.
Change committed as 179125

Powered by Google App Engine
This is Rietveld 408576698