Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422323003: Cleanup of context initialization (Closed)

Created:
6 years, 4 months ago by joshua.litt
Modified:
6 years, 4 months ago
CC:
reviews_skia.org, bsalomon_chromium
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup of context initialization Cleanup context initialization on linux BUG=skia: Committed: https://skia.googlesource.com/skia/+/c863ab07c207aac5aae8b1593a2767a946682bca

Patch Set 1 #

Patch Set 2 : small cleanup #

Patch Set 3 : small fix #

Total comments: 2

Patch Set 4 : request compatability profile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -68 lines) Patch
M include/gpu/gl/SkNativeGLContext.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/gpu/gl/unix/SkNativeGLContext_unix.cpp View 1 2 3 6 chunks +57 lines, -68 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
joshua.litt
6 years, 4 months ago (2014-07-30 19:52:22 UTC) #1
joshua.litt
6 years, 4 months ago (2014-07-30 20:05:28 UTC) #2
joshua.litt
Bots are miscomparing, but it seems like this patch is working. On my local machines ...
6 years, 4 months ago (2014-08-06 20:46:08 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/422323003/diff/40001/src/gpu/gl/unix/SkNativeGLContext_unix.cpp File src/gpu/gl/unix/SkNativeGLContext_unix.cpp (right): https://codereview.chromium.org/422323003/diff/40001/src/gpu/gl/unix/SkNativeGLContext_unix.cpp#newcode205 src/gpu/gl/unix/SkNativeGLContext_unix.cpp:205: GLX_CONTEXT_PROFILE_MASK_ARB, GLX_CONTEXT_CORE_PROFILE_BIT_ARB, We weren't setting this before, but ...
6 years, 4 months ago (2014-08-07 20:39:15 UTC) #4
bsalomon
My comments were from the old patchset. I forgot to delete them before publishing.
6 years, 4 months ago (2014-08-07 20:40:26 UTC) #5
joshua.litt
The CQ bit was checked by joshualitt@chromium.org
6 years, 4 months ago (2014-08-07 20:41:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/joshualitt@chromium.org/422323003/60001
6 years, 4 months ago (2014-08-07 20:41:45 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 20:48:55 UTC) #8
Message was sent while issue was closed. 
Change committed as c863ab07c207aac5aae8b1593a2767a946682bca

Powered by Google App Engine
This is Rietveld 408576698