Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422023005: Remove relative path to GrColor.h in SkShader.h (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, gw280
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove relative path to GrColor.h in SkShader.h Committed: https://skia.googlesource.com/skia/+/939f430f660d26e46116a38d2a8436afbd55dfb9

Patch Set 1 #

Patch Set 2 : Fix no-gpu build #

Patch Set 3 : really fix no-gpu build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M gyp/core.gyp View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
bsalomon
6 years, 4 months ago (2014-07-28 19:02:31 UTC) #1
bungeman-skia
lgtm fro Skia, but of course watch for this changing something out in cc in ...
6 years, 4 months ago (2014-07-28 19:15:35 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-28 19:19:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422023005/1
6 years, 4 months ago (2014-07-28 19:20:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-28 19:25:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 19:27:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/893)
6 years, 4 months ago (2014-07-28 19:27:17 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-28 19:34:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422023005/20001
6 years, 4 months ago (2014-07-28 19:35:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-28 19:42:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 19:43:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/896)
6 years, 4 months ago (2014-07-28 19:43:18 UTC) #12
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-28 19:57:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422023005/40001
6 years, 4 months ago (2014-07-28 19:57:37 UTC) #14
commit-bot: I haz the power
Change committed as 939f430f660d26e46116a38d2a8436afbd55dfb9
6 years, 4 months ago (2014-07-28 20:27:41 UTC) #15
bsalomon
6 years, 4 months ago (2014-07-28 20:41:43 UTC) #16
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/423943005/ by bsalomon@google.com.

The reason for reverting is: As Ben suspected, this breaks the chrome build..

Powered by Google App Engine
This is Rietveld 408576698