Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 421883006: Merge 286045 "Revert of mac: Fix tab dragging visual bug in Yose..." (Closed)

Created:
6 years, 4 months ago by matthewyuan
Modified:
6 years, 4 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Merge 286045 "Revert of mac: Fix tab dragging visual bug in Yose..." > Revert of mac: Fix tab dragging visual bug in Yosemite. (reland 2) (https://codereview.chromium.org/399803002/) > > Reason for revert: > NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#> > > https://code.google.com/p/chromium/issues/detail?id=397089 > > Original issue's description: > > mac: Fix tab dragging visual bug in Yosemite. (reland 2) > > -----------------Reland 2 Description------------------ > > Turned on layers for the test for fullscreen windows. > > > > -----------------Reland 1 Description------------------ > > Reland 1 link: https://codereview.chromium.org/393933003/ > > Core animation was turned on in M35. The fullscreen window was not layer > > backed, but should have been. This original CL exposed this bug. > > > > -----------------Original Description------------------ > > Original CL link: https://codereview.chromium.org/379293003/ > > > > In OSX 10.10+, all views must be added to the NSWindow's contentView. Some > > views (like the tab strip and the profile icon) are placed on top of the title > > bar and require special treatment. All other views are added as subviews of > > 'chromeContentView' in TabWindowController. This allows tab dragging and > > fullscreen logic to easily move the views that don't need special treatment. > > > > This CL also removes the instances where a VersionIndependentWindow's > > contentView gets replaced by setContentView:. Instead, the 'chromeContentView' > > gets passed around as a subview. This allows VersionIndependentWindow to remove > > another of its internal hacks. > > > > BUG=392239 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283650 > > TBR=shess@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=392239 > > Review URL: https://codereview.chromium.org/423013005 TBR=erikchen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -51 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 5 chunks +8 lines, -24 lines 0 comments Download
M chrome/browser/ui/cocoa/version_independent_window.mm View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
matthewyuan
6 years, 4 months ago (2014-07-29 04:07:14 UTC) #1
matthewyuan
6 years, 4 months ago (2014-07-29 04:07:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r286079 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698