Chromium Code Reviews
DescriptionMerge 286045 "Revert of mac: Fix tab dragging visual bug in Yose..."
> Revert of mac: Fix tab dragging visual bug in Yosemite. (reland 2) (https://codereview.chromium.org/399803002/)
>
> Reason for revert:
> NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#>
>
> https://code.google.com/p/chromium/issues/detail?id=397089
>
> Original issue's description:
> > mac: Fix tab dragging visual bug in Yosemite. (reland 2)
> > -----------------Reland 2 Description------------------
> > Turned on layers for the test for fullscreen windows.
> >
> > -----------------Reland 1 Description------------------
> > Reland 1 link: https://codereview.chromium.org/393933003/
> > Core animation was turned on in M35. The fullscreen window was not layer
> > backed, but should have been. This original CL exposed this bug.
> >
> > -----------------Original Description------------------
> > Original CL link: https://codereview.chromium.org/379293003/
> >
> > In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
> > views (like the tab strip and the profile icon) are placed on top of the title
> > bar and require special treatment. All other views are added as subviews of
> > 'chromeContentView' in TabWindowController. This allows tab dragging and
> > fullscreen logic to easily move the views that don't need special treatment.
> >
> > This CL also removes the instances where a VersionIndependentWindow's
> > contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
> > gets passed around as a subview. This allows VersionIndependentWindow to remove
> > another of its internal hacks.
> >
> > BUG=392239
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283650
>
> TBR=shess@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=392239
>
> Review URL: https://codereview.chromium.org/423013005
TBR=erikchen@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286079
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||