Revert of mac: Fix tab dragging visual bug in Yosemite. (reland 2)

Revert of mac: Fix tab dragging visual bug in Yosemite. (reland 2) (https://codereview.chromium.org/399803002/)

Reason for revert:
NSInvalidArgumentException reason Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#>	

https://code.google.com/p/chromium/issues/detail?id=397089

Original issue's description:
> mac: Fix tab dragging visual bug in Yosemite. (reland 2)
> -----------------Reland 2 Description------------------
> Turned on layers for the test for fullscreen windows.
> 
> -----------------Reland 1 Description------------------
> Reland 1 link: https://codereview.chromium.org/393933003/
> Core animation was turned on in M35. The fullscreen window was not layer
> backed, but should have been. This original CL exposed this bug.
> 
> -----------------Original Description------------------
> Original CL link: https://codereview.chromium.org/379293003/
> 
> In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
> views (like the tab strip and the profile icon) are placed on top of the title
> bar and require special treatment. All other views are added as subviews of
> 'chromeContentView' in TabWindowController. This allows tab dragging and
> fullscreen logic to easily move the views that don't need special treatment.
> 
> This CL also removes the instances where a VersionIndependentWindow's
> contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
> gets passed around as a subview. This allows VersionIndependentWindow to remove
> another of its internal hacks.
> 
> BUG=392239
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283650

TBR=shess@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392239
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286045

[erikchen, 2014-07-29 01:17:32]

Created Revert of mac: Fix tab dragging visual bug in Yosemite. (reland 2)

[commit-bot: I haz the power, 2014-07-29 01:19:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/423013005/1

[commit-bot: I haz the power, 2014-07-29 01:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:21:19]

Failed to apply patch for chrome/browser/ui/cocoa/version_independent_window.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/cocoa/version_independent_window.mm
  Hunk #1 succeeded at 53 (offset 23 lines).
  Hunk #2 FAILED at 79.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/cocoa/version_independent_window.mm.rej

Patch:       chrome/browser/ui/cocoa/version_independent_window.mm
Index: chrome/browser/ui/cocoa/version_independent_window.mm
diff --git a/chrome/browser/ui/cocoa/version_independent_window.mm
b/chrome/browser/ui/cocoa/version_independent_window.mm
index
98dacb313550247cd9182e3d86d9085b9c61e67c..24284a490d064e8b943e5d236653544bd56db79c
100644
--- a/chrome/browser/ui/cocoa/version_independent_window.mm
+++ b/chrome/browser/ui/cocoa/version_independent_window.mm
@@ -30,6 +30,12 @@
   if ([self superview])
     size = [[self superview] bounds].size;
   [super setFrameSize:size];
+}
+
+// The contentView gets moved around during certain full-screen operations.
+// This is less than ideal, and should eventually be removed.
+- (void)viewDidMoveToSuperview {
+  [self setFrame:[[self superview] bounds]];
 }
 
 @end
@@ -73,8 +79,8 @@
       chromeWindowView_.reset([[FullSizeContentView alloc] init]);
       [chromeWindowView_
           setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
+      [chromeWindowView_ setFrame:[[[self contentView] superview] bounds]];
       [self setContentView:chromeWindowView_];
-      [chromeWindowView_ setFrame:[[[self contentView] superview] bounds]];
     }
   }
   return self;

[erikchen, 2014-07-29 01:27:32]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:28:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/423013005/1

[commit-bot: I haz the power, 2014-07-29 01:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:29:43]

Failed to apply patch for chrome/browser/ui/cocoa/version_independent_window.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/cocoa/version_independent_window.mm
  Hunk #1 succeeded at 53 (offset 23 lines).
  Hunk #2 FAILED at 79.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/cocoa/version_independent_window.mm.rej

Patch:       chrome/browser/ui/cocoa/version_independent_window.mm
Index: chrome/browser/ui/cocoa/version_independent_window.mm
diff --git a/chrome/browser/ui/cocoa/version_independent_window.mm
b/chrome/browser/ui/cocoa/version_independent_window.mm
index
98dacb313550247cd9182e3d86d9085b9c61e67c..24284a490d064e8b943e5d236653544bd56db79c
100644
--- a/chrome/browser/ui/cocoa/version_independent_window.mm
+++ b/chrome/browser/ui/cocoa/version_independent_window.mm
@@ -30,6 +30,12 @@
   if ([self superview])
     size = [[self superview] bounds].size;
   [super setFrameSize:size];
+}
+
+// The contentView gets moved around during certain full-screen operations.
+// This is less than ideal, and should eventually be removed.
+- (void)viewDidMoveToSuperview {
+  [self setFrame:[[self superview] bounds]];
 }
 
 @end
@@ -73,8 +79,8 @@
       chromeWindowView_.reset([[FullSizeContentView alloc] init]);
       [chromeWindowView_
           setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
+      [chromeWindowView_ setFrame:[[[self contentView] superview] bounds]];
       [self setContentView:chromeWindowView_];
-      [chromeWindowView_ setFrame:[[[self contentView] superview] bounds]];
     }
   }
   return self;

[erikchen, 2014-07-29 01:35:08]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:37:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/423013005/1

[commit-bot: I haz the power, 2014-07-29 01:39:30]

Change committed as 286045

[Scott Hess - ex-Googler, 2014-07-29 01:41:31]

lgtm