Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 421663003: Move variations component code to variations namespace. (Closed)

Created:
6 years, 5 months ago by Alexei Svitkine (slow)
Modified:
6 years, 5 months ago
Reviewers:
Mathieu, jwd, sky
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, tfarina, browser-components-watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, asvitkine+watch_chromium.org, caitkp+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, Ilya Sherman
Project:
chromium
Visibility:
Public.

Description

Move variations component code to variations namespace. This is a re-land of https://codereview.chromium.org/412943002/ which broke on the official builder. BUG=284540 TBR=sky@chromium.org, mathp@chromium.org, jwd@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285778

Patch Set 1 : Original CL #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -206 lines) Patch
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/enhanced_bookmarks_features.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_elf_init_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 9 chunks +27 lines, -25 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/variations/experiment_labels.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/variations/experiment_labels_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/variations/uniformity_field_trials.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M components/rappor/rappor_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/suggestions_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/suggestions/suggestions_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/variations/android/variations_associated_data_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/processed_study.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/processed_study.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/proto/study.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/proto/variations_seed.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/study_filtering.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/study_filtering.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_associated_data.h View 4 chunks +13 lines, -13 lines 0 comments Download
M components/variations/variations_associated_data.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M components/variations/variations_associated_data_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/variations/variations_http_header_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/variations/variations_http_header_provider.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/variations/variations_http_header_provider_unittest.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M components/variations/variations_seed_processor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_simulator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_simulator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_simulator_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 5 months ago (2014-07-25 21:30:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/421663003/20001
6 years, 5 months ago (2014-07-25 21:33:39 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 23:32:28 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 23:45:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/46966)
6 years, 5 months ago (2014-07-25 23:45:04 UTC) #5
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 5 months ago (2014-07-26 02:51:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/421663003/20001
6 years, 5 months ago (2014-07-26 05:00:18 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 18:35:51 UTC) #8
Message was sent while issue was closed.
Change committed as 285778

Powered by Google App Engine
This is Rietveld 408576698