Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/variations/variations_associated_data.h

Issue 421663003: Move variations component code to variations namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_associated_data.h
===================================================================
--- components/variations/variations_associated_data.h (revision 285608)
+++ components/variations/variations_associated_data.h (working copy)
@@ -37,11 +37,11 @@
//
// VariationID id = GetGoogleVariationID(GOOGLE_WEB_PROPERTIES, "trial",
// "group1");
-// if (id != chrome_variations::kEmptyID) {
+// if (id != variations::kEmptyID) {
// // use |id|
// }
-namespace chrome_variations {
+namespace variations {
typedef int VariationID;
@@ -64,13 +64,13 @@
ID_COLLECTION_COUNT,
};
-// Associate a chrome_variations::VariationID value with a FieldTrial group for
+// Associate a variations::VariationID value with a FieldTrial group for
// collection |key|. If an id was previously set for |trial_name| and
// |group_name|, this does nothing. The group is denoted by |trial_name| and
// |group_name|. This must be called whenever a FieldTrial is prepared (create
-// the trial and append groups) and needs to have a
-// chrome_variations::VariationID associated with it so Google servers can
-// recognize the FieldTrial. Thread safe.
+// the trial and append groups) and needs to have a variations::VariationID
+// associated with it so Google servers can recognize the FieldTrial.
+// Thread safe.
void AssociateGoogleVariationID(IDCollectionKey key,
const std::string& trial_name,
const std::string& group_name,
@@ -82,12 +82,12 @@
const std::string& group_name,
VariationID id);
-// Retrieve the chrome_variations::VariationID associated with a FieldTrial
-// group for collection |key|. The group is denoted by |trial_name| and
-// |group_name|. This will return chrome_variations::kEmptyID if there is
-// currently no associated ID for the named group. This API can be nicely
-// combined with FieldTrial::GetActiveFieldTrialGroups() to enumerate the
-// variation IDs for all active FieldTrial groups. Thread safe.
+// Retrieve the variations::VariationID associated with a FieldTrial group for
+// collection |key|. The group is denoted by |trial_name| and |group_name|.
+// This will return variations::kEmptyID if there is currently no associated ID
+// for the named group. This API can be nicely combined with
+// FieldTrial::GetActiveFieldTrialGroups() to enumerate the variation IDs for
+// all active FieldTrial groups. Thread safe.
VariationID GetGoogleVariationID(IDCollectionKey key,
const std::string& trial_name,
const std::string& group_name);
@@ -131,6 +131,6 @@
} // namespace testing
-} // namespace chrome_variations
+} // namespace variations
#endif // COMPONENTS_VARIATIONS_VARIATIONS_ASSOCIATED_DATA_H_
« no previous file with comments | « components/variations/study_filtering_unittest.cc ('k') | components/variations/variations_associated_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698