components/metrics/metrics_service.h - Issue 421653005: Adding synthetic field trial for DataReductionProxyEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.h

Issue 421653005: Adding synthetic field trial for DataReductionProxyEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newPltWithCL

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/metrics_service.h

diff --git a/components/metrics/metrics_service.h b/components/metrics/metrics_service.h

index b0dcb82beaa053d5a89fbeed8fefffdb5f2e1f76..65b795a16f904734202fef42276837ba431368fb 100644

--- a/components/metrics/metrics_service.h

+++ b/components/metrics/metrics_service.h

@@ -67,7 +67,9 @@ struct SyntheticTrialGroup {

base::TimeTicks start_time;

private:

+ //Synthetic field trial users:

friend class MetricsService;

+ friend class DataReductionProxyChromeSettings;

Alexei Svitkine (slow) 2014/07/30 17:27:04 This is a layering violation, since the component

megjablon 2014/07/30 18:50:48 Done.

FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, RegisterSyntheticTrial);

// This constructor is private specifically so as to control which code is