components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h - Issue 421653005: Adding synthetic field trial for DataReductionProxyEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h

Issue 421653005: Adding synthetic field trial for DataReductionProxyEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newPltWithCL

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc » ('j') | components/metrics/metrics_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h b/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h

index b24f239ceb011b9ed208b3a62e6badd1bb0a65a9..cdfa225ab7b297ddd00a4df24e1bb7df471445c5 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.h

@@ -162,6 +162,11 @@ class DataReductionProxySettingsTestBase : public testing::Test {

scoped_ptr<DataReductionProxySettings> settings_;

scoped_ptr<TestDataReductionProxyParams> expected_params_;

base::Time last_update_time_;

+ bool proxy_enabled_;

+ void RegisterSyntheticFieldTrialCallback(bool proxy_enabled) {

Alexei Svitkine (slow) 2014/07/30 17:27:04 Functions should come before variables.

megjablon 2014/07/30 18:50:48 Done.

+ proxy_enabled_ = proxy_enabled;

+ }

};

// Test implementations should be subclasses of an instantiation of this