Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 421623004: Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (Closed)

Created:
6 years, 5 months ago by aurimas (slooooooooow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (https://codereview.chromium.org/403273003/) Reason for revert: It broke the component builds. Original issue's description: > Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 > > Blink should make use of blink_resources.grd for the inline resources of inspector. > This removes the dependency upon using xxd.py which embeds these resources as strings. > > Part 1: https://crrev.com/401233003 > Part 3: https://crrev.com/402033002 > > BUG=312586 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436 TBR=jochen@chromium.org,abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aurimas (slooooooooow)
Created Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part ...
6 years, 5 months ago (2014-07-25 21:45:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/421623004/1
6 years, 5 months ago (2014-07-25 21:47:13 UTC) #2
commit-bot: I haz the power
Change committed as 285701
6 years, 5 months ago (2014-07-25 22:04:02 UTC) #3
Nico
> It broke the component builds. That's surprising to me, given that this was in ...
6 years, 5 months ago (2014-07-25 22:08:46 UTC) #4
aurimas (slooooooooow)
On 2014/07/25 22:08:46, Nico (away) wrote: > > It broke the component builds. > > ...
6 years, 5 months ago (2014-07-25 22:24:34 UTC) #5
Elliot Glaysher
On 2014/07/25 22:08:46, Nico (away) wrote: > > It broke the component builds. > > ...
6 years, 5 months ago (2014-07-25 22:29:56 UTC) #6
Nico
On 2014/07/25 22:29:56, Elliot Glaysher wrote: > On 2014/07/25 22:08:46, Nico (away) wrote: > > ...
6 years, 5 months ago (2014-07-25 22:42:05 UTC) #7
vivekg
6 years, 5 months ago (2014-07-26 02:50:30 UTC) #8
Message was sent while issue was closed.
On 2014/07/25 22:29:56, Elliot Glaysher wrote:
> On 2014/07/25 22:08:46, Nico (away) wrote:
> > > It broke the component builds.
> > 
> > That's surprising to me, given that this was in the tree for quite a while
> (and
> > we have component build bots). Do you have a link to a broken bot?
> 
> I hit this locally. I can confirm that this fixes the build errors locally. I
> don't know of any bot catching this...

Can you please check if your blink repo had the changes done in part 1 of the
patch series? This is a 3 part patch as below

Part 1 in Blink: https://crrev.com/401233003
Part 2 in Chromium: https://codereview.chromium.org/403273003/
Part 3 in Blink: https://crrev.com/402033002

Earlier yesterday, vollick also faced similar issue. Pasting the conversation
here for reference:

7:41 PM <+vollick> vivekg: ping
7:42 PM <+vollick> My ToT build is failing on mac. It's dying in
blink_platform_impl.cc. Can't find a bunch of resources.
7:42 PM <+vollick> Am I doing something wrong?
7:48 PM <thakis_> vollick: which binary are you running?
7:49 PM <thakis_> (resource loading on mac requires some setup things; maybe
vivekg didn’t add thisi to whatever binary you’re using)
7:50 PM <+vollick> Sorry, I should have been clearer. It's dying during
compilation.
7:51 PM <thakis_> oh. if the bots are green, then that’s probably some issue on
your side. all repos synced?
7:52 PM <+vollick> I thought so too. Git blame pointed at
https://codereview.chromium.org/403273003
7:52 PM <+vollick> I think I may just be missing patch 3 in the series.
7:58 PM <+vollick> That doesn't seem to be it. I wonder if some generated files
are stale and aren't getting updated? I'm going to blow away my out/ dir and try
again..
9:30 PM <+vollick> thakis_: That was it. Wiping out/ and starting fresh worked
great. Sorry for the noise.

Powered by Google App Engine
This is Rietveld 408576698