Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2

Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2

Blink should make use of blink_resources.grd for the inline resources of inspector.
This removes the dependency upon using xxd.py which embeds these resources as strings.

Part 1: https://crrev.com/401233003
Part 3: https://crrev.com/402033002

BUG=312586
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436

[vivekg, 2014-07-21 09:23:42]

PTAL, thank you!

[jochen (gone - plz use gerrit), 2014-07-21 11:28:43]

lgtm

[vivekg, 2014-07-24 18:11:49]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-24 18:14:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/403273003/20001

[commit-bot: I haz the power, 2014-07-24 22:26:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-25 00:30:13]

Change committed as 285436

[aurimas (slooooooooow), 2014-07-25 21:13:27]

On 2014/07/25 00:30:13, I haz the power (commit-bot) wrote:
> Change committed as 285436

Component builds on Android are now failing with:

../../content/child/blink_platform_impl.cc:759:34: error:
'IDR_INSPECTOR_OVERLAY_PAGE_HTML' was not declared in this scope
   { "InspectorOverlayPage.html", IDR_INSPECTOR_OVERLAY_PAGE_HTML,
                                  ^
../../content/child/blink_platform_impl.cc:762:5: error:
'IDR_INSPECTOR_INJECTED_SCRIPT_CANVAS_MODULE_SOURCE_JS' was not declared in this
scope
     IDR_INSPECTOR_INJECTED_SCRIPT_CANVAS_MODULE_SOURCE_JS,
     ^
../../content/child/blink_platform_impl.cc:764:32: error:
'IDR_INSPECTOR_INJECTED_SCRIPT_SOURCE_JS' was not declared in this scope
   { "InjectedScriptSource.js", IDR_INSPECTOR_INJECTED_SCRIPT_SOURCE_JS,
                                ^
../../content/child/blink_platform_impl.cc:766:32: error:
'IDR_INSPECTOR_DEBUGGER_SCRIPT_SOURCE_JS' was not declared in this scope
   { "DebuggerScriptSource.js", IDR_INSPECTOR_DEBUGGER_SCRIPT_SOURCE_JS,
                                ^
[12468/13838] CXX obj/content/common/content.content_message_generator.o

[Elliot Glaysher, 2014-07-25 21:40:53]

Component builds on Linux (at least 64bit Precise with clang) are failing with:

../../content/child/blink_platform_impl.cc:759:34: error: use of undeclared
identifier 'IDR_INSPECTOR_OVERLAY_PAGE_HTML'
  { "InspectorOverlayPage.html", IDR_INSPECTOR_OVERLAY_PAGE_HTML,
                                 ^
../../content/child/blink_platform_impl.cc:762:5: error: use of undeclared
identifier 'IDR_INSPECTOR_INJECTED_SCRIPT_CANVAS_MODULE_SOURCE_JS'
    IDR_INSPECTOR_INJECTED_SCRIPT_CANVAS_MODULE_SOURCE_JS,
    ^
../../content/child/blink_platform_impl.cc:764:32: error: use of undeclared
identifier 'IDR_INSPECTOR_INJECTED_SCRIPT_SOURCE_JS'
  { "InjectedScriptSource.js", IDR_INSPECTOR_INJECTED_SCRIPT_SOURCE_JS,
                               ^
../../content/child/blink_platform_impl.cc:766:32: error: use of undeclared
identifier 'IDR_INSPECTOR_DEBUGGER_SCRIPT_SOURCE_JS'
  { "DebuggerScriptSource.js", IDR_INSPECTOR_DEBUGGER_SCRIPT_SOURCE_JS,
                               ^
../../content/child/blink_platform_impl.cc:799:26: error: no matching function
for call to 'ArraySizeHelper'
  for (size_t i = 0; i < arraysize(kDataResources); ++i) {
                         ^~~~~~~~~~~~~~~~~~~~~~~~~
../../base/macros.h:74:34: note: expanded from macro 'arraysize'
#define arraysize(array) (sizeof(ArraySizeHelper(array)))
                                 ^~~~~~~~~~~~~~~
../../base/macros.h:64:8: note: candidate template ignored: could not match 'T
[N]' against 'const content::(anonymous namespace)::DataResource []'
char (&ArraySizeHelper(T (&array)[N]))[N];
       ^
../../base/macros.h:71:8: note: candidate template ignored: could not match
'const T [N]' against 'const content::(anonymous namespace)::DataResource []'
char (&ArraySizeHelper(const T (&array)[N]))[N];
       ^
5 errors generated.

Can we get this reverted asap?

[aurimas (slooooooooow), 2014-07-25 21:45:19]

A revert of this CL has been created in
https://codereview.chromium.org/421623004/ by aurimas@chromium.org.

The reason for reverting is: It broke the component builds..

[vivekg, 2014-07-26 02:11:09]

On 2014/07/25 21:45:19, aurimas wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/421623004/ by mailto:aurimas@chromium.org.
> 
> The reason for reverting is: It broke the component builds..

I am bit surprised that the component builds are braking for this. I have the
same environment and i tested this for even android. Having said that, this
revert also should revert part 1 and part 3 blink side changes. I will look into
what is causing the build failure.

[vivekg, 2014-07-26 03:08:52]

On 2014/07/26 02:11:09, vivekg_ wrote:
> On 2014/07/25 21:45:19, aurimas wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/421623004/ by mailto:aurimas@chromium.org.
> > 
> > The reason for reverting is: It broke the component builds..
> 
> I am bit surprised that the component builds are braking for this. I have the
> same environment and i tested this for even android. Having said that, this
> revert also should revert part 1 and part 3 blink side changes. I will look
into
> what is causing the build failure.

oh there was a PSA here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ZHPXuuzRwL0