Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 42153002: Merge 230360 "[mac] Support adding the launcher to the Dock when..." (Closed)

Created:
7 years, 2 months ago by tapted
Modified:
7 years, 2 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Merge 230360 "[mac] Support adding the launcher to the Dock when..." > [mac] Support adding the launcher to the Dock when Dashboard.app is present. > > Dashboard has a special tile-type of "dashboard-tile" (rather than > "file-tile"), and no file-data, when it is present in a user's Dock. > dock::AddIcon(..) currently emits an error when encountering these dock > tiles. > > This CL will detect the case of a Dock tile with no file-data, and > substitute a dummy path (the empty string) to align with the source data > dictionary. > > For the App Launcher, this CL also adds some error handling for > dock::AddIcon. This allows the app launcher creation code to pop up the > Finder window when adding the icon to the Dock fails. > > BUG=309941 > TEST=Drag "Dashboard" from /Applications to the Dock, and enable the app > launcher in a fresh Chrome install. You should get an app launcher added > to the Dock. > > Review URL: https://codereview.chromium.org/32563004 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M chrome/browser/mac/dock.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/mac/dock.mm View 7 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
7 years, 2 months ago (2013-10-24 22:34:07 UTC) #1
tapted
7 years, 2 months ago (2013-10-24 22:35:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r230851.

Powered by Google App Engine
This is Rietveld 408576698