[mac] Support adding the launcher to the Dock when Dashboard.app is present.

[mac] Support adding the launcher to the Dock when Dashboard.app is present.

Dashboard has a special tile-type of "dashboard-tile" (rather than
"file-tile"), and no file-data, when it is present in a user's Dock.
dock::AddIcon(..) currently emits an error when encountering these dock
tiles.

This CL will detect the case of a Dock tile with no file-data, and
substitute a dummy path (the empty string) to align with the source data
dictionary.

For the App Launcher, this CL also adds some error handling for
dock::AddIcon. This allows the app launcher creation code to pop up the
Finder window when adding the icon to the Dock fails.

BUG=309941
TEST=Drag "Dashboard" from /Applications to the Dock, and enable the app
launcher in a fresh Chrome install. You should get an app launcher added
to the Dock.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230360

[tapted, 2013-10-22 04:05:42]

mark: please review for chrome/browser/mac
benwells: please review for chrome/browser/web_applications

Thanks!

[benwells, 2013-10-22 07:38:27]

lgtm

[tapted, 2013-10-22 23:06:25]

+thakis Nico, are you comfortable reviewing this change? Mark is OOO this week..
hoping to get this in for m31. But if it's too alien I might still be able to
wait, and butter up the release maintainer..

[Nico, 2013-10-23 00:21:10]

This lgtm. One question below (but code is fine):

https://codereview.chromium.org/32563004/diff/1/chrome/browser/web_applicatio...
File chrome/browser/web_applications/web_app_mac.mm (right):

https://codereview.chromium.org/32563004/diff/1/chrome/browser/web_applicatio...
chrome/browser/web_applications/web_app_mac.mm:504: }
I don't understand this part of the change. Why is this part of the CL? Why is
opening the app shim in finder on "create shortcut" a desired ui flow?

[tapted, 2013-10-23 00:59:23]

Thanks Nico!

https://codereview.chromium.org/32563004/diff/1/chrome/browser/web_applicatio...
File chrome/browser/web_applications/web_app_mac.mm (right):

https://codereview.chromium.org/32563004/diff/1/chrome/browser/web_applicatio...
chrome/browser/web_applications/web_app_mac.mm:504: }
On 2013/10/23 00:21:11, Nico wrote:
> I don't understand this part of the change. Why is this part of the CL? Why is
> opening the app shim in finder on "create shortcut" a desired ui flow?

Yeah - hopefully this UI flow can be avoided.

With this change, if it's clear that adding the App Launcher tile to the Dock
failed, opening a Finder window with the shortcut highlighted gives someone an
opportunity to drag it in themselves. Initial feedback had a few people caught
by the bug confused; hunting for the launcher icon that was in the webstore
messaging. With this fix, hopefully any remaining cases will be very rare (but
following up with some UMA might be a good idea... - made
http://crbug.com/310388 ).

For normal installs the flow shouldn't be hit. But, the messaging is controlled
server-side. So (hypothetically) if a Mac point release was to break this
suddenly, different instructions could be shown, based on user agent. That's not
ideal, but Apple seem to want it to be hard to add things to the Dock -- there
was a nice CoreDock private API that got disabled in Lion, but this flow still
works.

[commit-bot: I haz the power, 2013-10-23 01:05:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/32563004/1

[commit-bot: I haz the power, 2013-10-23 07:08:35]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-23 07:20:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/32563004/1

[commit-bot: I haz the power, 2013-10-23 07:23:17]

Change committed as 230360