Issue 421513002: Use webGL context creation attribute to activate GLSL validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421513002: Use webGL context creation attribute to activate GLSL validation (Closed)

Created:
6 years, 5 months ago by oetuaho-nv

Modified:
6 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use webGL context creation attribute to activate GLSL validation Previously, GLSL validation was implicitly enabled on contexts that had the noExtensions flag on. Use the webGL flag instead, making the code less fragile. BUG=397183 TEST=WebGL conformance tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285887

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Thank you for cleaning this up. LGTM

6 years, 5 months ago (2014-07-25 21:32:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/421513002/1

6 years, 4 months ago (2014-07-28 07:17:22 UTC) #4

Message was sent while issue was closed.

Change committed as 285887

Expand Messages | Collapse Messages