content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 421513002: Use webGL context creation attribute to activate GLSL validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 421513002: Use webGL context creation attribute to activate GLSL validation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index e7c945f3ceafbf059efc90d19cc6576516979369..3bf0eebd8cb67bc4d34107d85d7155548a7b9dac 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -156,9 +156,7 @@ bool WebGraphicsContext3DCommandBufferImpl::MaybeInitializeGL() {

return false;

}

- // TODO(twiz): This code is too fragile in that it assumes that only WebGL

- // contexts will request noExtensions.

- if (gl_ && attributes_.noExtensions)

+ if (gl_ && attributes_.webGL)

gl_->EnableFeatureCHROMIUM("webgl_enable_glsl_webgl_validation");

command_buffer_->SetChannelErrorCallback(

« no previous file with comments | « no previous file | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('j') | no next file with comments »