Issue 421473002: Re-enable mojo_core_window_manager_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421473002: Re-enable mojo_core_window_manager_unittests (Closed)

Created:
6 years, 4 months ago by jamesr

Modified:
6 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Re-enable mojo_core_window_manager_unittests These now pass thanks to Tim's shutdown fixes. BUG=396295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285522

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	mojo/services/window_manager/window_manager_api_unittest.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
	M	mojo/services/window_manager/window_manager_app.cc	View		2 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

I'm not really sure exactly how to resolve this with https://codereview.chromium.org/400113005. Took a guess in ...

6 years, 4 months ago (2014-07-25 00:20:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/421473002/1

6 years, 4 months ago (2014-07-25 01:37:39 UTC) #4

Message was sent while issue was closed.

Change committed as 285522

Expand Messages | Collapse Messages