Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 400113005: A new WM bootstrap flow (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

As discussed, a new WM bootstrap flow. First off, create a new window manager app (wm_flow_wm) which uses the core_window_manager_lib static lib to implement a basic WM. Second, create a new demo launcher (wm_flow_init) that starts the view manager, embeds wm_flow_wm, and starts an additional app (wm_flow_app). Thirdly, creates an additional app (wm_flow_app) that also connects to the view manager init service and asks it to embed it somewhere, thus giving it a connection to the view manager (and a top-level window). I had to change ViewManagerInitService to have some shared state so that it was possible to connect to it > 1 time. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285345

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : , #

Patch Set 9 : . #

Total comments: 4

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -52 lines) Patch
A + mojo/examples/wm_flow/app/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/examples/wm_flow/app/app.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +77 lines, -0 lines 0 comments Download
A mojo/examples/wm_flow/init/init.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +48 lines, -0 lines 0 comments Download
A + mojo/examples/wm_flow/wm/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/examples/wm_flow/wm/wm.cc View 1 2 3 4 5 6 7 8 1 chunk +89 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 6 7 8 9 4 chunks +16 lines, -4 lines 0 comments Download
M mojo/services/view_manager/main.cc View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -1 line 0 comments Download
A mojo/services/view_manager/view_manager_init_service_context.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +59 lines, -0 lines 0 comments Download
A mojo/services/view_manager/view_manager_init_service_context.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +69 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.h View 1 2 3 4 5 6 4 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.cc View 1 2 3 4 5 6 7 8 3 chunks +19 lines, -22 lines 0 comments Download
A mojo/services/window_manager/main.cc View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -5 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 2 3 4 5 6 7 8 9 4 chunks +5 lines, -10 lines 0 comments Download
M mojo/shell/view_manager_loader.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/view_manager_loader.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 5 months ago (2014-07-24 05:13:46 UTC) #1
sky
LGTM https://codereview.chromium.org/400113005/diff/160001/mojo/examples/wm_flow/app/app.cc File mojo/examples/wm_flow/app/app.cc (right): https://codereview.chromium.org/400113005/diff/160001/mojo/examples/wm_flow/app/app.cc#newcode23 mojo/examples/wm_flow/app/app.cc:23: class WMFlowApp : public mojo::ApplicationDelegate, Please add descriptions ...
6 years, 5 months ago (2014-07-24 16:43:28 UTC) #2
Ben Goodger (Google)
6 years, 5 months ago (2014-07-24 19:04:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #11 manually as r285345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698