Source/platform/text/BidiRunList.h - Issue 421463002: Have BidiRunList destructor delete runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/text/BidiRunList.h

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/text/BidiRunList.h

diff --git a/Source/platform/text/BidiRunList.h b/Source/platform/text/BidiRunList.h

index bfaaab0de9cc576609802973d6cda072e7a29716..d800be787bdf65bfc268f7b64e847e45131c0e4a 100644

--- a/Source/platform/text/BidiRunList.h

+++ b/Source/platform/text/BidiRunList.h

@@ -40,8 +40,7 @@ public:

{

}

- // FIXME: Once BidiResolver no longer owns the BidiRunList,

- // then ~BidiRunList should call deleteRuns() automatically.

+ ~BidiRunList() { deleteRuns(); }

Run* firstRun() const { return m_firstRun; }

Run* lastRun() const { return m_lastRun; }