Source/core/rendering/svg/SVGTextMetricsBuilder.cpp - Issue 421463002: Have BidiRunList destructor delete runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

diff --git a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

index a9336c3e95e14e40a1b6289a77a4176ebc05f7dd..da5b86beabde3ad2772240e740c6f1c4a1ccde9e 100644

--- a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

+++ b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

@@ -40,7 +40,7 @@ namespace blink {

class SVGTextMetricsCalculator {

public:

SVGTextMetricsCalculator(RenderSVGInlineText*);

- ~SVGTextMetricsCalculator();

+ ~SVGTextMetricsCalculator() { }

leviw_travelin_and_unemployed 2014/07/28 20:34:17 Can this just be removed?

SVGTextMetrics computeMetricsForCharacter(unsigned textPosition);

unsigned textLength() const { return static_cast<unsigned>(m_run.charactersLength()); }

@@ -90,11 +90,6 @@ SVGTextMetricsCalculator::SVGTextMetricsCalculator(RenderSVGInlineText* text)

setupBidiRuns();

}

-SVGTextMetricsCalculator::~SVGTextMetricsCalculator()

- m_bidiRuns.deleteRuns();

void SVGTextMetricsCalculator::setupBidiRuns()

{

RenderStyle* style = m_text->style();

« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/platform/graphics/GraphicsContext.cpp » ('j') | no next file with comments »