Source/platform/graphics/GraphicsContext.cpp - Issue 421463002: Have BidiRunList destructor delete runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/GraphicsContext.cpp

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/svg/SVGTextMetricsBuilder.cpp ('K') | « Source/core/rendering/svg/SVGTextMetricsBuilder.cpp ('k') | Source/platform/text/BidiResolverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/GraphicsContext.cpp

diff --git a/Source/platform/graphics/GraphicsContext.cpp b/Source/platform/graphics/GraphicsContext.cpp

index 2059e793cf41e1e9b474440f2b9ef503dd761d15..04be58b550e32698f3bdc64508d84f08dcb223b3 100644

--- a/Source/platform/graphics/GraphicsContext.cpp

+++ b/Source/platform/graphics/GraphicsContext.cpp

@@ -975,8 +975,6 @@ void GraphicsContext::drawBidiText(const Font& font, const TextRunPaintInfo& run

if (bidiRun)

currPoint.move(font.width(subrun), 0);

}

- bidiRuns.deleteRuns();

}

void GraphicsContext::drawHighlightForText(const Font& font, const TextRun& run, const FloatPoint& point, int h, const Color& backgroundColor, int from, int to)