Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: Source/core/rendering/RenderBlockLineLayout.cpp

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderBlockLineLayout.cpp
diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp
index e68107b917c5314768cb6b64f85f0f98dd8a4313..ce2f703ced80ff2532148199abb0823023d308e5 100644
--- a/Source/core/rendering/RenderBlockLineLayout.cpp
+++ b/Source/core/rendering/RenderBlockLineLayout.cpp
@@ -820,7 +820,10 @@ void RenderBlockFlow::layoutRunsAndFloatsInRange(LineLayoutState& layoutState,
renderTextInfo.m_lineBreakIterator.resetPriorContext();
if (resolver.position().atEnd()) {
// FIXME: We shouldn't be creating any runs in nextLineBreak to begin with!
- // Once BidiRunList is separated from BidiResolver this will not be needed.
+ // Figure out why we create new runs in nextLineBreak and why we
+ // seem to rely on that behavior.
+ // Removing the addRun calls in LineBreaker::skipLeadingWhitespace
+ // breaks a bunch of bidi layout tests.
bidiRuns.deleteRuns();
resolver.markCurrentRunEmpty(); // FIXME: This can probably be replaced by an ASSERT (or just removed).
layoutState.setCheckForFloatsFromLastLine(true);
« no previous file with comments | « no previous file | Source/core/rendering/RenderText.cpp » ('j') | Source/core/rendering/svg/SVGTextMetricsBuilder.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698