Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 421463002: Have BidiRunList destructor delete runs (Closed)

Created:
6 years, 5 months ago by eae
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jamesr, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+bidiwatch_chromium.org, leviw+renderwatch, pdr., rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Have BidiRunList destructor delete runs Have the BidiRunList destructor delete all runs and change all BidiRunList call sites, except RenderBlockLineLayout, to rely on the destructor instead of explicit calls to deleteRuns. In RenderBlockFlow::layoutRunsAndFloatsInRange deleteRuns is called early, and explicitly, in two places. Removing these calls would likely involve splitting the run list of changing the life time of it. BUG=396963 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179177

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed SVGTextMetricsCalculator destructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/text/BidiResolverTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/text/BidiRunList.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eae
6 years, 5 months ago (2014-07-24 23:28:19 UTC) #1
eae
6 years, 5 months ago (2014-07-25 15:35:50 UTC) #2
eae
Ping?
6 years, 4 months ago (2014-07-28 20:30:23 UTC) #3
leviw_travelin_and_unemployed
https://codereview.chromium.org/421463002/diff/1/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp File Source/core/rendering/svg/SVGTextMetricsBuilder.cpp (right): https://codereview.chromium.org/421463002/diff/1/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp#newcode43 Source/core/rendering/svg/SVGTextMetricsBuilder.cpp:43: ~SVGTextMetricsCalculator() { } Can this just be removed?
6 years, 4 months ago (2014-07-28 20:34:17 UTC) #4
eae
On 2014/07/28 20:34:17, leviw wrote: > https://codereview.chromium.org/421463002/diff/1/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp > File Source/core/rendering/svg/SVGTextMetricsBuilder.cpp (right): > > https://codereview.chromium.org/421463002/diff/1/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp#newcode43 > ...
6 years, 4 months ago (2014-07-29 00:47:37 UTC) #5
leviw_travelin_and_unemployed
lgtm
6 years, 4 months ago (2014-07-29 20:12:26 UTC) #6
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 4 months ago (2014-07-29 20:12:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/421463002/20001
6 years, 4 months ago (2014-07-29 20:12:53 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 22:06:25 UTC) #9
Message was sent while issue was closed.
Change committed as 179177

Powered by Google App Engine
This is Rietveld 408576698