Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/platform/text/BidiRunList.h

Issue 421463002: Have BidiRunList destructor delete runs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: removed SVGTextMetricsCalculator destructor Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/platform/text/BidiResolverTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2006, 2007, 2008 Apple Inc. All right reserved. 3 * Copyright (C) 2003, 2004, 2006, 2007, 2008 Apple Inc. All right reserved.
4 * Copyright (C) 2011 Google, Inc. All rights reserved. 4 * Copyright (C) 2011 Google, Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 22 matching lines...) Expand all
33 WTF_MAKE_NONCOPYABLE(BidiRunList); 33 WTF_MAKE_NONCOPYABLE(BidiRunList);
34 public: 34 public:
35 BidiRunList() 35 BidiRunList()
36 : m_firstRun(0) 36 : m_firstRun(0)
37 , m_lastRun(0) 37 , m_lastRun(0)
38 , m_logicallyLastRun(0) 38 , m_logicallyLastRun(0)
39 , m_runCount(0) 39 , m_runCount(0)
40 { 40 {
41 } 41 }
42 42
43 // FIXME: Once BidiResolver no longer owns the BidiRunList, 43 ~BidiRunList() { deleteRuns(); }
44 // then ~BidiRunList should call deleteRuns() automatically.
45 44
46 Run* firstRun() const { return m_firstRun; } 45 Run* firstRun() const { return m_firstRun; }
47 Run* lastRun() const { return m_lastRun; } 46 Run* lastRun() const { return m_lastRun; }
48 Run* logicallyLastRun() const { return m_logicallyLastRun; } 47 Run* logicallyLastRun() const { return m_logicallyLastRun; }
49 unsigned runCount() const { return m_runCount; } 48 unsigned runCount() const { return m_runCount; }
50 49
51 void addRun(Run*); 50 void addRun(Run*);
52 void prependRun(Run*); 51 void prependRun(Run*);
53 52
54 void moveRunToEnd(Run*); 53 void moveRunToEnd(Run*);
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 m_firstRun = endRun; 243 m_firstRun = endRun;
245 244
246 startRun->m_next = afterEnd; 245 startRun->m_next = afterEnd;
247 if (!afterEnd) 246 if (!afterEnd)
248 m_lastRun = startRun; 247 m_lastRun = startRun;
249 } 248 }
250 249
251 } // namespace blink 250 } // namespace blink
252 251
253 #endif // BidiRunList 252 #endif // BidiRunList
OLDNEW
« no previous file with comments | « Source/platform/text/BidiResolverTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698