Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: test/mac/gyptest-strip.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mac/gyptest-strip.py
diff --git a/test/mac/gyptest-strip.py b/test/mac/gyptest-strip.py
index e2c06c13589eb8359b9828dbadcdef192040572d..cc4d73e78eec42fce61dc32929fddd4527bdf6b3 100755
--- a/test/mac/gyptest-strip.py
+++ b/test/mac/gyptest-strip.py
@@ -19,7 +19,9 @@ import time
if sys.platform == 'darwin':
test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
- test.run_gyp('test.gyp', chdir='strip')
+ test.run_gyp('test.gyp',
+ '-G', 'xcode_ninja_target_pattern=^.*$',
+ chdir='strip')
test.build('test.gyp', test.ALL, chdir='strip')
@@ -41,7 +43,8 @@ if sys.platform == 'darwin':
# with Xcode 5.0 or higher, take this additional symbol into consideration
# for unstripped builds (it is stripped by all strip commands).
expected_extra_symbol_count = 0
- if test.format == 'ninja' and TestMac.Xcode.Version() >= '0500':
+ if test.format in ['ninja', 'xcode-ninja'] \
+ and TestMac.Xcode.Version() >= '0500':
expected_extra_symbol_count = 1
# The actual numbers here are not interesting, they just need to be the same

Powered by Google App Engine
This is Rietveld 408576698