test/ninja/action_dependencies/gyptest-action-dependencies.py - Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/ninja/action_dependencies/gyptest-action-dependencies.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase onto origin/master Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« test/mac/gyptest-loadable-module-bundle-product-extension.py ('K') | « test/many-actions/gyptest-many-actions-unsorted.py ('k') | test/ninja/chained-dependency/gyptest-chained-dependency.py » ('j') | test/ninja/chained-dependency/gyptest-chained-dependency.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/ninja/action_dependencies/gyptest-action-dependencies.py

diff --git a/test/ninja/action_dependencies/gyptest-action-dependencies.py b/test/ninja/action_dependencies/gyptest-action-dependencies.py

index 9c5acea8cb3b087d6383e2d912071a16a953d97b..dbfd277ce8d8aa1647e4ae60bdfbf980836768d8 100755

--- a/test/ninja/action_dependencies/gyptest-action-dependencies.py

+++ b/test/ninja/action_dependencies/gyptest-action-dependencies.py

@@ -21,6 +21,8 @@ import TestGyp

# which I don't think is available on all generators.

# TODO(piman): Extend to other generators when possible.

test = TestGyp.TestGyp(formats=['ninja'])

+if test.format == 'xcode-ninja':

sdefresne 2014/09/02 15:13:05 Please document why this test is ignored when usin

Tobias 2014/10/02 18:19:19 As explained in the comment above "NOTE(piman) [..

+ test.skip_test()

test.run_gyp('action_dependencies.gyp', chdir='src')