Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Issue 421413003: Turn off scalarize_vec_and_mat_constructor_args workaround everywhere (Closed)

Created:
6 years, 4 months ago by Zhenyao Mo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Turn off scalarize_vec_and_mat_constructor_args workaround everywhere There is a bug in the workaround, so we should fix it before turning it on. This is simply removing a few entries in the json file, plus surpressing affected WebGL conformance tests. Very safe CL. BUG=398694 TEST=gpu_unitests, gpu linux bots green TBR=kbr@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -35 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +20 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-07-30 01:52:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/421413003/1
6 years, 4 months ago (2014-07-30 01:52:48 UTC) #2
commit-bot: I haz the power
Change committed as 286406
6 years, 4 months ago (2014-07-30 03:55:16 UTC) #3
jonnialva90
lgtm Index: gpu/config/gpu_driver_bug_list_json.cc diff --git a/gpu/config/gpu_driver_bug_list_json.cc b/gpu/config/gpu_driver_bug_list_json.cc index 190faf6eae7628fc67a380432d44460ee80ec2b1..30ddda861a1b53a331eca030cae665bf5b675521 100644 --- a/gpu/config/gpu_driver_bug_list_json.cc +++ b/gpu/config/gpu_driver_bug_list_json.cc @@ ...
4 years, 7 months ago (2016-05-24 20:35:01 UTC) #5
jonnialva90
4 years, 7 months ago (2016-05-25 18:33:04 UTC) #6
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698