Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 421413002: run-webkit-tests: fix crash when trying to read a log that did not exist. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

run-webkit-tests: fix crash when trying to read a log that did not exist. During error recovery after failing to start a server, there might actually not be an error log where we think there should be one. TBR=eseidel@chromium.org BUG=378444 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-07-28 22:10:22 UTC) #1
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-07-28 22:10:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/421413002/1
6 years, 4 months ago (2014-07-28 22:11:39 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-28 23:59:04 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 00:39:25 UTC) #5
Message was sent while issue was closed.
Change committed as 179077

Powered by Google App Engine
This is Rietveld 408576698