Tools/Scripts/webkitpy/layout_tests/servers/server_base.py - Issue 421413002: run-webkit-tests: fix crash when trying to read a log that did not exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

Issue 421413002: run-webkit-tests: fix crash when trying to read a log that did not exist. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py b/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

index 827371faeabe5087478295a7febf4bbe61094743..854a9070d075ea8d5e3dad8e6f508fae12a48a99 100644

--- a/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

+++ b/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

@@ -210,7 +210,7 @@ class ServerBase(object):

_log.error('%s no stderr handle' % self._name)

else:

_log.error('%s no process' % self._name)

- if self._error_log_path:

+ if self._error_log_path and self._filesystem.exists(self._error_log_path):

error_log_text = self._filesystem.read_text_file(self._error_log_path)

if error_log_text:

_log.error('%s error log (%s) contents:' % (self._name, self._error_log_path))

« no previous file with comments | « no previous file | no next file » | no next file with comments »