Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
421253006:
Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type (Closed)
|
Created:
6 years, 4 months ago by Vitaly Pavlenko Modified:
6 years, 4 months ago Reviewers:
Dan Beam CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@A_typechecking_about Project:
chromium Visibility:
Public. |
DescriptionAdd ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type
BUG=393873
R=dbeam@chromium.org
TEST=python2 third_party/closure_compiler/coding_conventions_test.py
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287727
Patch Set 1 #
Total comments: 24
Patch Set 2 : Fix comments #
Total comments: 10
Patch Set 3 : FileCache and fixes #
Total comments: 8
Patch Set 4 : final fixes #
Total comments: 4
Patch Set 5 : remove exit_on_fatal flag #
Total comments: 14
Patch Set 6 : fatal -> error #
Total comments: 6
Patch Set 7 : final final final final #
Total comments: 2
Patch Set 8 : remove redundant constructor #Patch Set 9 : remove runner.jar from patch #Patch Set 10 : rebase onto master #
Messages
Total messages: 24 (0 generated)
https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... File third_party/closure_compiler/compile_modules.py (right): https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/compile_modules.py:41: allowed = required + ["depends", "externs", "expected_output"] this should not be in production code, figure out a way to only allow this key to exist from tests. https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... File third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java (right): https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:17: import java.util.List; ^ unused https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:22: private static final long serialVersionUID = 1L; ^ unused? https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:26: "Object literal expected as second argument"); ^ unused? https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:38: "superClass_", why do we need superClass_? https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:49: // Use both the original name and the post-CollapseProperties name. ^ remove after removing $ version https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:51: callArg.matchesQualifiedName("cr$addSingletonGetter")) || ^ don't need the $ version https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... File third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java (right): https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java:196: throws FlagUsageException, IOException { 4 more \s indent on L196 https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... File third_party/closure_compiler/tests/getInstance_test.js (right): https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/tests/getInstance_test.js:7: }; ^ unused https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/tests/getInstance_test.js:32: cr.addSingletonGetter = function(ctor) { can this file be: var cr = { /** @param {!Function} ctor */ addSingletonGetter: function(ctor) { ctor.getInstance = function() { return ctor.instance_ || (ctor.instance_ = new ctor()); }; } }; /** @constructor */ function Class() { /** @param {number} num */ this.needsNumber = function(num) {}; } cr.addSingletonGetter(Class); Class.getInstance().needsNumber("wrong type"); https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... File third_party/closure_compiler/tests/test.resources (right): https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/tests/test.resources:4: [ i don't like this format because: - it separates the test asserts/results in 2 files - it addes more logic to the tests - this .resources file isn't actually used to compile resources https://codereview.chromium.org/421253006/diff/1/third_party/closure_compiler... third_party/closure_compiler/tests/test.resources:10: "expected_output": ''' ''' -> """
https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... File third_party/closure_compiler/compile_modules.py (right): https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/compile_modules.py:41: allowed = required + ["depends", "externs", "expected_output"] On 2014/07/29 18:05:10, Dan Beam wrote: > this should not be in production code, figure out a way to only allow this key > to exist from tests. Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... File third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java (right): https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:17: import java.util.List; On 2014/07/29 18:05:11, Dan Beam wrote: > ^ unused Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:22: private static final long serialVersionUID = 1L; On 2014/07/29 18:05:11, Dan Beam wrote: > ^ unused? Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:26: "Object literal expected as second argument"); On 2014/07/29 18:05:11, Dan Beam wrote: > ^ unused? Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:38: "superClass_", On 2014/07/29 18:05:11, Dan Beam wrote: > why do we need superClass_? Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:49: // Use both the original name and the post-CollapseProperties name. On 2014/07/29 18:05:11, Dan Beam wrote: > ^ remove after removing $ version Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:51: callArg.matchesQualifiedName("cr$addSingletonGetter")) || On 2014/07/29 18:05:11, Dan Beam wrote: > ^ don't need the $ version Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... File third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java (right): https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java:196: throws FlagUsageException, IOException { On 2014/07/29 18:05:12, Dan Beam wrote: > 4 more \s indent on L196 Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... File third_party/closure_compiler/tests/getInstance_test.js (right): https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/tests/getInstance_test.js:7: }; On 2014/07/29 18:05:12, Dan Beam wrote: > ^ unused Acknowledged. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/tests/getInstance_test.js:32: cr.addSingletonGetter = function(ctor) { On 2014/07/29 18:05:12, Dan Beam wrote: > can this file be: > > var cr = { > /** @param {!Function} ctor */ > addSingletonGetter: function(ctor) { > ctor.getInstance = function() { > return ctor.instance_ || (ctor.instance_ = new ctor()); > }; > } > }; > > /** @constructor */ > function Class() { > /** @param {number} num */ > this.needsNumber = function(num) {}; > } > > cr.addSingletonGetter(Class); > Class.getInstance().needsNumber("wrong type"); Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... File third_party/closure_compiler/tests/test.resources (right): https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/tests/test.resources:4: [ On 2014/07/29 18:05:12, Dan Beam wrote: > i don't like this format because: > - it separates the test asserts/results in 2 files > - it addes more logic to the tests > - this .resources file isn't actually used to compile resources Done. https://chromiumcodereview.appspot.com/421253006/diff/1/third_party/closure_c... third_party/closure_compiler/tests/test.resources:10: "expected_output": ''' On 2014/07/29 18:05:12, Dan Beam wrote: > ''' -> """ Acknowledged.
https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/checker.py:219: return output why not just return both the output and returncode as a tuple? https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:14: def rel_to_abs(rel_path): unused https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:27: def _runCheckerTest(self, config): only used once, adds more code https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:34: print >> temp_file, file_content just sutff the file into FileCache._cache instead of writing a temp file and removing it (just like I did...) https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:40: test_name, expected_output, output)) "{}".format() -> "%s" % ()
https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/checker.py:219: return output On 2014/07/29 19:17:16, Dan Beam wrote: > why not just return both the output and returncode as a tuple? Done. https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:14: def rel_to_abs(rel_path): On 2014/07/29 19:17:16, Dan Beam wrote: > unused Done. https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:27: def _runCheckerTest(self, config): On 2014/07/29 19:17:17, Dan Beam wrote: > only used once, adds more code Done. https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:34: print >> temp_file, file_content On 2014/07/29 19:17:16, Dan Beam wrote: > just sutff the file into FileCache._cache instead of writing a temp file and > removing it (just like I did...) Done. https://chromiumcodereview.appspot.com/421253006/diff/20001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:40: test_name, expected_output, output)) On 2014/07/29 19:17:16, Dan Beam wrote: > "{}".format() -> "%s" % () Done.
lgtm https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:6: import argparse don't need ^ https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:56: opts = parser.parse_args() ^ unused https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... File third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java (right): https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:33: "getInstance"); nit: fits in 1 line now
https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/checker.py:132: sys.exit(1) ^ actually, just return the exit code rather than dying here
https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/checker.py:132: sys.exit(1) On 2014/07/29 21:51:47, Dan Beam wrote: > ^ actually, just return the exit code rather than dying here Done. https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:6: import argparse On 2014/07/29 21:50:45, Dan Beam wrote: > don't need ^ Done. https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/coding_conventions_test.py:56: opts = parser.parse_args() On 2014/07/29 21:50:46, Dan Beam wrote: > ^ unused Done. https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... File third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java (right): https://chromiumcodereview.appspot.com/421253006/diff/40001/third_party/closu... third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java:33: "getInstance"); On 2014/07/29 21:50:46, Dan Beam wrote: > nit: fits in 1 line now Done.
https://chromiumcodereview.appspot.com/421253006/diff/60001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/60001/third_party/closu... third_party/closure_compiler/checker.py:108: def __init__(self, verbose=False, exit_on_fatal=True): remove this parameter https://chromiumcodereview.appspot.com/421253006/diff/60001/third_party/closu... third_party/closure_compiler/checker.py:135: return 1 i meant return 1 as the exit code of calling check()
https://chromiumcodereview.appspot.com/421253006/diff/60001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/60001/third_party/closu... third_party/closure_compiler/checker.py:108: def __init__(self, verbose=False, exit_on_fatal=True): On 2014/07/29 23:27:44, Dan Beam wrote: > remove this parameter Done. https://chromiumcodereview.appspot.com/421253006/diff/60001/third_party/closu... third_party/closure_compiler/checker.py:135: return 1 On 2014/07/29 23:27:44, Dan Beam wrote: > i meant return 1 as the exit code of calling check() Done.
https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:128: def _fatal(self, msg): change to _error, _fatal no longer makes as much sense https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:129: print >> sys.stderr, "(FATAL) " + msg (ERROR) https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:140: def _check_java_path(self): if not self._found_java: proc = self._run_command(["which", "java"]) proc.communicate() if proc.returncode == 0: self._found_java = True else self._error("Cannot find java (`which java` => %s)" % proc.returncode) return self._found_java https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:179: def check(self, file, depends=[], externs=[]): if not self._check_java_path(): return 1, "" https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:222: return runner_cmd.returncode == 0, output return runner_cmd.returncode, output https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... File third_party/closure_compiler/compile_modules.py (right): https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/compile_modules.py:98: success, _ = self._checker.check(rel_path(s), depends=depends, exit_code, _ = ... https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/compile_modules.py:100: if not success: if exit_code: sys.exit(exit_code)
https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... File third_party/closure_compiler/checker.py (right): https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:128: def _fatal(self, msg): On 2014/07/29 23:49:08, Dan Beam wrote: > change to _error, _fatal no longer makes as much sense Done. https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:129: print >> sys.stderr, "(FATAL) " + msg On 2014/07/29 23:49:08, Dan Beam wrote: > (ERROR) Done. https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:140: def _check_java_path(self): On 2014/07/29 23:49:08, Dan Beam wrote: > if not self._found_java: > proc = self._run_command(["which", "java"]) > proc.communicate() > if proc.returncode == 0: > self._found_java = True > else > self._error("Cannot find java (`which java` => %s)" % proc.returncode) > > return self._found_java Done. https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:179: def check(self, file, depends=[], externs=[]): On 2014/07/29 23:49:08, Dan Beam wrote: > if not self._check_java_path(): > return 1, "" Done. https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/checker.py:222: return runner_cmd.returncode == 0, output On 2014/07/29 23:49:08, Dan Beam wrote: > return runner_cmd.returncode, output Done. https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... File third_party/closure_compiler/compile_modules.py (right): https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/compile_modules.py:98: success, _ = self._checker.check(rel_path(s), depends=depends, On 2014/07/29 23:49:08, Dan Beam wrote: > exit_code, _ = ... Done. https://chromiumcodereview.appspot.com/421253006/diff/80001/third_party/closu... third_party/closure_compiler/compile_modules.py:100: if not success: On 2014/07/29 23:49:08, Dan Beam wrote: > if exit_code: > sys.exit(exit_code) Done.
slgtm https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... third_party/closure_compiler/coding_conventions_test.py:14: self.maxDiff = None ^ remove this __init__, maxDiff is only used in assertMultiLine() i think https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... third_party/closure_compiler/coding_conventions_test.py:20: test_name = "getInstance" just inline "getInstance" instead of making |test_name| https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... File third_party/closure_compiler/compile_modules.py (right): https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... third_party/closure_compiler/compile_modules.py:99: externs=externs) indent off
https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... third_party/closure_compiler/coding_conventions_test.py:14: self.maxDiff = None On 2014/07/30 00:13:05, Dan Beam wrote: > ^ remove this __init__, maxDiff is only used in assertMultiLine() i think Done. https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... third_party/closure_compiler/coding_conventions_test.py:20: test_name = "getInstance" On 2014/07/30 00:13:05, Dan Beam wrote: > just inline "getInstance" instead of making |test_name| Done. https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... File third_party/closure_compiler/compile_modules.py (right): https://chromiumcodereview.appspot.com/421253006/diff/100001/third_party/clos... third_party/closure_compiler/compile_modules.py:99: externs=externs) On 2014/07/30 00:13:05, Dan Beam wrote: > indent off Done.
https://chromiumcodereview.appspot.com/421253006/diff/120001/third_party/clos... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/120001/third_party/clos... third_party/closure_compiler/coding_conventions_test.py:13: unittest.TestCase.__init__(self, *args, **kwargs) ^ this __init__ method is the same as not having this code at all, please remove
https://chromiumcodereview.appspot.com/421253006/diff/120001/third_party/clos... File third_party/closure_compiler/coding_conventions_test.py (right): https://chromiumcodereview.appspot.com/421253006/diff/120001/third_party/clos... third_party/closure_compiler/coding_conventions_test.py:13: unittest.TestCase.__init__(self, *args, **kwargs) On 2014/07/30 00:40:53, Dan Beam wrote: > ^ this __init__ method is the same as not having this code at all, please remove Done.
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/421253006/160001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/35408) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/40439) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/35433)
The CQ bit was checked by vitalyp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/421253006/180001
Message was sent while issue was closed.
Change committed as 287727 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
