third_party/closure_compiler/tests/test.resources - Issue 421253006: Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/closure_compiler/tests/test.resources

Issue 421253006: Add ChromeCodingConvention.java to Closure Compiler to preserve getInstance() type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@A_typechecking_about

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # -- python --

	2 # ex: set syntax=python:

	3

	4 [
	Dan Beam 2014/07/29 18:05:12 i don't like this format because: - it separates t i don't like this format because: - it separates the test asserts/results in 2 files - it addes more logic to the tests - this .resources file isn't actually used to compile resources Vitaly Pavlenko 2014/07/29 18:53:46 Done. Show quoted text On 2014/07/29 18:05:12, Dan Beam wrote: > i don't like this format because: > - it separates the test asserts/results in 2 files > - it addes more logic to the tests > - this .resources file isn't actually used to compile resources Done.
	5 {

	6 "name": "getInstance_test",

	7 "sources": [

	8 "getInstance_test.js",

	9 ],

	10 "expected_output": '''
	Dan Beam 2014/07/29 18:05:12 ''' -> """ ''' -> """ Vitaly Pavlenko 2014/07/29 18:53:46 Acknowledged. Show quoted text On 2014/07/29 18:05:12, Dan Beam wrote: > ''' -> """ Acknowledged.
	11 WARNING - Property whatever never defined on myModule.myClass

	12 WARNING - actual parameter 1 of myModule.myBaseClass.prototype.myMethod does not match formal parameter

	13 '''

	14 },

	15 ]

OLD	NEW

« third_party/closure_compiler/tests/getInstance_test.js ('K') | « third_party/closure_compiler/tests/getInstance_test.js ('k') | no next file » | no next file with comments »