Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 421183003: Revert of Add builders for tracing event's structural arguments (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Add builders for tracing event's structural arguments (https://codereview.chromium.org/380763002/) Reason for revert: linux ASAN errors. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4493/steps/base_unittests/logs/stdio Original issue's description: > Add builders for tracing event's structural arguments > > The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code. > > All clients of cc/debug/traced_value.h should eventually switch to use the new builders. > > BUG=361045 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286849 TBR=alph, caseq, dsinclair, nduca, willchan, yurys NOTREECHECKS=true NOTRY=true BUG=361045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+893 lines, -1361 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D base/debug/trace_event_argument.h View 1 chunk +0 lines, -57 lines 0 comments Download
D base/debug/trace_event_argument.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D base/debug/trace_event_argument_unittest.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M base/debug/trace_event_impl.h View 1 chunk +1 line, -8 lines 0 comments Download
M cc/base/math_util.h View 2 chunks +10 lines, -29 lines 0 comments Download
M cc/base/math_util.cc View 4 chunks +45 lines, -57 lines 0 comments Download
M cc/base/region.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/base/region.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M cc/debug/frame_viewer_instrumentation.h View 3 chunks +18 lines, -15 lines 0 comments Download
M cc/debug/rendering_stats.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/debug/rendering_stats.cc View 3 chunks +28 lines, -32 lines 0 comments Download
M cc/debug/rendering_stats_unittest.cc View 4 chunks +27 lines, -13 lines 0 comments Download
M cc/debug/traced_picture.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/debug/traced_value.h View 1 chunk +36 lines, -14 lines 0 comments Download
M cc/debug/traced_value.cc View 3 chunks +29 lines, -18 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_impl.cc View 6 chunks +35 lines, -61 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +14 lines, -26 lines 0 comments Download
M cc/layers/surface_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/layers/tiled_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/output/begin_frame_args.h View 2 chunks +1 line, -10 lines 0 comments Download
M cc/output/begin_frame_args.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M cc/output/filter_operation.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/output/filter_operation.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M cc/output/filter_operations.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/output/filter_operations.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M cc/quads/checkerboard_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/checkerboard_draw_quad.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/content_draw_quad_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/content_draw_quad_base.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M cc/quads/debug_border_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/debug_border_draw_quad.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/draw_quad.h View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/quads/draw_quad.cc View 2 chunks +17 lines, -29 lines 0 comments Download
M cc/quads/io_surface_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/io_surface_draw_quad.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/quads/picture_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/picture_draw_quad.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/quads/render_pass.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/quads/render_pass.cc View 2 chunks +14 lines, -27 lines 0 comments Download
M cc/quads/render_pass_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/render_pass_draw_quad.cc View 2 chunks +8 lines, -17 lines 0 comments Download
M cc/quads/shared_quad_state.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/quads/shared_quad_state.cc View 2 chunks +11 lines, -22 lines 0 comments Download
M cc/quads/solid_color_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/solid_color_draw_quad.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/stream_video_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/stream_video_draw_quad.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/quads/surface_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/surface_draw_quad.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/texture_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/texture_draw_quad.cc View 2 chunks +6 lines, -15 lines 0 comments Download
M cc/quads/tile_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/tile_draw_quad.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/yuv_video_draw_quad.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/resources/image_copy_raster_worker_pool.h View 2 chunks +2 lines, -9 lines 0 comments Download
M cc/resources/image_copy_raster_worker_pool.cc View 5 chunks +23 lines, -15 lines 0 comments Download
M cc/resources/image_raster_worker_pool.h View 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M cc/resources/managed_tile_state.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/managed_tile_state.cc View 4 chunks +28 lines, -19 lines 0 comments Download
M cc/resources/picture.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M cc/resources/picture_pile_base.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/resources/picture_pile_base.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.h View 2 chunks +2 lines, -9 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 4 chunks +24 lines, -15 lines 0 comments Download
M cc/resources/raster_mode.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/raster_mode.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M cc/resources/tile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile.cc View 2 chunks +10 lines, -22 lines 0 comments Download
M cc/resources/tile_manager.h View 3 chunks +4 lines, -13 lines 0 comments Download
M cc/resources/tile_manager.cc View 5 chunks +19 lines, -28 lines 0 comments Download
M cc/resources/tile_priority.h View 7 chunks +10 lines, -8 lines 0 comments Download
M cc/resources/tile_priority.cc View 1 chunk +51 lines, -36 lines 0 comments Download
M cc/scheduler/delay_based_time_source.h View 2 chunks +2 lines, -7 lines 0 comments Download
M cc/scheduler/delay_based_time_source.cc View 2 chunks +19 lines, -14 lines 0 comments Download
M cc/scheduler/scheduler.h View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/scheduler/scheduler.cc View 8 chunks +46 lines, -51 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 2 chunks +2 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 2 chunks +1 line, -6 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 4 chunks +86 lines, -87 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 7 chunks +15 lines, -16 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +4 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +32 lines, -72 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +1 line, -7 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +14 lines, -12 lines 0 comments Download
M cc/trees/proxy.h View 2 chunks +3 lines, -7 lines 0 comments Download
M cc/trees/proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +12 lines, -9 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 3 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
erikchen
Created Revert of Add builders for tracing event's structural arguments
6 years, 4 months ago (2014-07-31 18:52:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/421183003/1
6 years, 4 months ago (2014-07-31 18:54:39 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 18:54:40 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 18:54:41 UTC) #4
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 4 months ago (2014-07-31 18:59:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/421183003/1
6 years, 4 months ago (2014-07-31 18:59:53 UTC) #6
commit-bot: I haz the power
Change committed as 286862
6 years, 4 months ago (2014-07-31 19:02:13 UTC) #7
willchan no longer on Chromium
lgtm On Thu, Jul 31, 2014 at 12:02 PM, <commit-bot@chromium.org> wrote: > Change committed as ...
6 years, 4 months ago (2014-07-31 19:12:32 UTC) #8
willchan no longer on Chromium
6 years, 4 months ago (2014-07-31 19:19:35 UTC) #9
Message was sent while issue was closed.
lgtm

I always forget to use rietveld for this.

Powered by Google App Engine
This is Rietveld 408576698