Issue 42097: Make wrapper-context.html faster by eliminating timeouts....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42097: Make wrapper-context.html faster by eliminating timeouts.... (Closed)

Created:
11 years, 9 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make wrapper-context.html faster by eliminating timeouts. BUG=4391 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11584

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -29 lines)			Patch
M	webkit/data/layout_tests/chrome/fast/dom/resources/wrapper-context-inner.html	View	1 chunk	+8 lines, -12 lines	0 comments	Download
M	webkit/data/layout_tests/chrome/fast/dom/wrapper-context.html	View	1 chunk	+15 lines, -17 lines	0 comments	Download
M	webkit/data/layout_tests/chrome/fast/dom/wrapper-context-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

I *think* all I've done is replace the timeouts with cross-frame function calls, but since ...

11 years, 9 months ago (2009-03-11 22:40:27 UTC) #1

Mads Ager (chromium)

11 years, 9 months ago (2009-03-12 07:43:08 UTC) #2

LGTM

Setting innerDocument in the top frame and only then accessing document from the
inner frame is indeed the test case.  At some point, we accidentally created the
javascript wrapper for the document in the inner frame using the prototype chain
from the outer frame if the document was accessed from the outer frame first.

Expand Messages | Collapse Messages