Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(110)

Issue 42097: Make wrapper-context.html faster by eliminating timeouts.... (Closed)

Created:
10 years ago by Pam (message me for reviews)
Modified:
7 years, 8 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make wrapper-context.html faster by eliminating timeouts. BUG=4391 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11584

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M webkit/data/layout_tests/chrome/fast/dom/resources/wrapper-context-inner.html View 1 chunk +8 lines, -12 lines 0 comments Download
M webkit/data/layout_tests/chrome/fast/dom/wrapper-context.html View 1 chunk +15 lines, -17 lines 0 comments Download
M webkit/data/layout_tests/chrome/fast/dom/wrapper-context-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Pam (message me for reviews)
I *think* all I've done is replace the timeouts with cross-frame function calls, but since ...
10 years ago (2009-03-11 22:40:27 UTC) #1
Mads Ager (chromium)
10 years ago (2009-03-12 07:43:08 UTC) #2
LGTM

Setting innerDocument in the top frame and only then accessing document from the
inner frame is indeed the test case.  At some point, we accidentally created the
javascript wrapper for the document in the inner frame using the prototype chain
from the outer frame if the document was accessed from the outer frame first.

Powered by Google App Engine
This is Rietveld 408576698