Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 420923002: Revert 285701 "Revert of Migrate all usages of xxd.py to blink_r..." (Closed)

Created:
6 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 285701 "Revert of Migrate all usages of xxd.py to blink_r..." The original revert can not be done in isolation. There are dependent changes in Blink. This revert broke all of the tests on the GPU bots and likely tests on other bots. Undoing the revert. > Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (https://codereview.chromium.org/403273003/) > > Reason for revert: > It broke the component builds. > > Original issue's description: > > Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 > > > > Blink should make use of blink_resources.grd for the inline resources of inspector. > > This removes the dependency upon using xxd.py which embeds these resources as strings. > > > > Part 1: https://crrev.com/401233003 > > Part 3: https://crrev.com/402033002 > > > > BUG=312586 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436 > > TBR=jochen@chromium.org,abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com > NOTREECHECKS=true > NOTRY=true > BUG=312586 > > Review URL: https://codereview.chromium.org/421623004 TBR=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M trunk/src/content/child/blink_platform_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 5 months ago (2014-07-25 22:48:18 UTC) #1
Ken Russell (switch to Gerrit)
Committed patchset #1 manually as r285713 (tree was closed).
6 years, 5 months ago (2014-07-25 22:48:24 UTC) #2
varkha
On 2014/07/25 22:48:24, Ken Russell wrote: > Committed patchset #1 manually as r285713 (tree was ...
6 years, 5 months ago (2014-07-26 00:31:17 UTC) #3
varkha
On 2014/07/25 22:48:24, Ken Russell wrote: > Committed patchset #1 manually as r285713 (tree was ...
6 years, 5 months ago (2014-07-26 00:31:17 UTC) #4
Ken Russell (switch to Gerrit)
6 years, 5 months ago (2014-07-26 00:33:07 UTC) #5
Message was sent while issue was closed.
On 2014/07/26 00:31:17, varkha wrote:
> On 2014/07/25 22:48:24, Ken Russell wrote:
> > Committed patchset #1 manually as r285713 (tree was closed).
> 
> Does this re-break the component build?

Apparently a clobber build might be necessary, but otherwise, no, the component
build is fine. DevTools is completely broken with this revert in place.

See:

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZHPXuuzRwL0/oLgrt...

Powered by Google App Engine
This is Rietveld 408576698