Insertion handler appears anywhere on the page

Remove unused variable from TouchSelectionController

As of r286119, |selection_editable_for_last_update_| is no longer used by
TouchSelectionController. Remove accordingly.

BUG=397556
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286739

[raghu, 2014-07-25 16:55:37]

Hi jdduke,
The issue is that insertion handler is shown since selection controller's
editable flag remains set even after we navigate to a different page. 
Even the editable state in ImeAdapter is also stale in this case. 

With this change both the issues would be fixed. PTAL.

[raghu, 2014-07-28 14:25:29]

PTAL

[jdduke (slow), 2014-07-28 14:43:05]

The real problem is that we're hooking into the |is_selection_editable| check
wrong.  I'll take a closer look.

https://codereview.chromium.org/420853002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/420853002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_android.cc:499:
FocusedNodeChanged(false);
I'm not sure this is the right solution, and I don't think we should be
hijacking the "FocusedNodeChanged()" within this method.

[jdduke (slow), 2014-07-28 15:40:45]

On 2014/07/28 14:43:05, jdduke wrote:
> The real problem is that we're hooking into the |is_selection_editable| check
> wrong.  I'll take a closer look.
> 
>
https://codereview.chromium.org/420853002/diff/1/content/browser/renderer_hos...
> File content/browser/renderer_host/render_widget_host_view_android.cc (right):
> 
>
https://codereview.chromium.org/420853002/diff/1/content/browser/renderer_hos...
> content/browser/renderer_host/render_widget_host_view_android.cc:499:
> FocusedNodeChanged(false);
> I'm not sure this is the right solution, and I don't think we should be
> hijacking the "FocusedNodeChanged()" within this method.

See https://codereview.chromium.org/428623002/.

[jdduke (slow), 2014-07-28 21:50:02]

On 2014/07/28 15:40:45, jdduke wrote:
> See https://codereview.chromium.org/428623002/.

Scratch that, the fix is at https://codereview.chromium.org/425493004.

[raghu, 2014-07-29 12:38:27]

On 2014/07/28 21:50:02, jdduke wrote:
> On 2014/07/28 15:40:45, jdduke wrote:
> > See https://codereview.chromium.org/428623002/.
> 
> Scratch that, the fix is at https://codereview.chromium.org/425493004.

yes, looks like this will take care of all the issues. Just a small thing, now
that "selection_editable_for_last_update_" is redundant, may be we can delete
it.

[jdduke (slow), 2014-07-29 15:03:00]

On 2014/07/29 12:38:27, rvg wrote:
> On 2014/07/28 21:50:02, jdduke wrote:
> > On 2014/07/28 15:40:45, jdduke wrote:
> > > See https://codereview.chromium.org/428623002/.
> > 
> > Scratch that, the fix is at https://codereview.chromium.org/425493004.
> 
> yes, looks like this will take care of all the issues. Just a small thing, now
> that "selection_editable_for_last_update_" is redundant, may be we can delete
> it.

Hmm, you're right, good catch (feel free to post a patch removing it and I'll
approve).

[raghu, 2014-07-30 06:01:57]

PTAL

[jdduke (slow), 2014-07-30 18:22:55]

On 2014/07/30 06:01:57, rvg wrote:
> PTAL

lgtm, but in the future make sure to update patch descriptions as you change the
patch contents.

[jdduke (slow), 2014-07-30 18:23:17]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-07-30 18:25:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/420853002/20001

[commit-bot: I haz the power, 2014-07-30 20:04:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 21:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 21:03:56]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[raghu, 2014-07-31 03:23:03]

The CQ bit was checked by r.ghatage@samsung.com

[commit-bot: I haz the power, 2014-07-31 03:26:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/420853002/20001

[commit-bot: I haz the power, 2014-07-31 11:44:36]

Change committed as 286739

[raghu, 2014-07-31 16:50:19]

On 2014/07/30 18:22:55, jdduke wrote:
> On 2014/07/30 06:01:57, rvg wrote:
> > PTAL
> 
> lgtm, but in the future make sure to update patch descriptions as you change
the
> patch contents.

Thanks. Surely, I will take care about it.