Issue 425493004: [Android] Fix several selection handle-related issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425493004: [Android] Fix several selection handle-related issues (Closed)

Created:
6 years, 4 months ago by jdduke (slow)

Modified:
6 years, 4 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
ankit, chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, raghu, Cyan, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Fix several selection handle-related issues Several selection and insertion handle inconsistencies were introduced with the switch to composited rendering (r284491). This patch introduces the following behavior fixes: 1) Prevent handles from showing after programmatic selection events following a long press selection event. 2) Suppress insertion handle showing when the editable region is empty. 3) Reset the editable flag after navigation events. BUG=397514, 397802, 397556, 397204 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286119

Patch Set 1 #

Patch Set 2 : Cleanup #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -50 lines)			Patch
M	content/browser/renderer_host/input/touch_selection_controller.h	View	1	5 chunks	+19 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/input/touch_selection_controller.cc	View	1	9 chunks	+49 lines, -22 lines	0 comments	Download
M	content/browser/renderer_host/input/touch_selection_controller_unittest.cc	View		12 chunks	+73 lines, -17 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View		5 chunks	+17 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/425493004/20001

6 years, 4 months ago (2014-07-28 23:29:20 UTC) #4

Message was sent while issue was closed.

Change committed as 286119

Expand Messages | Collapse Messages