Source/bindings/templates/dictionary_v8.cpp - Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_methods.py ('K') | « Source/bindings/templates/dictionary_impl.cpp ('k') | Source/bindings/templates/templates.gypi » ('j') | Source/bindings/tests/results/TestDictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/dictionary_v8.cpp

diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp

index 74ab972f5cc8821d5b9d2d78c6a4e4e19e138027..7a1bce9cf6916bd8afea9fe97ac5107117ec2d9b 100644

--- a/Source/bindings/templates/dictionary_v8.cpp

+++ b/Source/bindings/templates/dictionary_v8.cpp

@@ -35,7 +35,7 @@ v8::Handle<v8::Value> toV8({{cpp_class}}* impl, v8::Handle<v8::Object> creationC

{

v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);

{% for member in members %}

- if (impl->{{member.has_name}}())

+ if (impl->{{member.has_method_name}}())

v8Object->Set(v8String(isolate, "{{member.name}}"), {{member.cpp_value_to_v8_value}});

{% if member.v8_default_value %}

else