Source/bindings/scripts/v8_methods.py - Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 420763002: IDL: DOM impl class code generation for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_dictionary.py ('K') | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | Source/bindings/tests/results/TestDictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 9e92e0ed43d273adc1b054f1be904578a42c0037..6d3178fff7b7df5ea12633a70da4d7587071fa84 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -251,7 +251,8 @@ def argument_declarations_for_private_script(interface, method):

argument_declarations = ['LocalFrame* frame']

argument_declarations.append('%s* holderImpl' % interface.name)

argument_declarations.extend(['%s %s' % (argument.idl_type.cpp_type_args(

- used_as_argument=True), argument.name) for argument in method.arguments])

+ used_as_rvalue_type=True), argument.name)

haraken 2014/07/29 11:09:19 Nit: 4-space indent

bashi 2014/07/29 23:59:49 Done.

+ for argument in method.arguments])

if method.idl_type.name != 'void':

argument_declarations.append('%s* %s' % (method.idl_type.cpp_type, 'result'))

return argument_declarations