IDL: DOM impl class code generation for IDL dictionaries

Source/bindings/scripts/v8_dictionary.py

Index: Source/bindings/scripts/v8_dictionary.py
diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py
index c9fd904a9e40a735cd075a397bbefb316506c1ff..70182103d401f27c0efbcfa444003640cc8edaba 100644
--- a/Source/bindings/scripts/v8_dictionary.py
+++ b/Source/bindings/scripts/v8_dictionary.py
@@ -28,7 +28,7 @@ def setter_name_for_dictionary_member(member):
     return 'set%s' % v8_utilities.capitalize(member.name)
 
 
-def has_name_for_dictionary_member(member):
+def has_method_name_for_dictionary_member(member):
     return 'has%s' % v8_utilities.capitalize(member.name)
 
 
@@ -79,11 +79,64 @@ def member_context(member):
             cpp_value='impl->%s()' % member.name, isolate='isolate',
             creation_context='creationContext',
             extended_attributes=member.extended_attributes),
-        'has_name': has_name_for_dictionary_member(member),
+        'has_method_name': has_method_name_for_dictionary_member(member),
         'name': member.name,
         'setter_name': setter_name_for_dictionary_member(member),
         'v8_default_value': v8_default_value,
         'v8_type': v8_types.v8_type(idl_type.base_type),
     }
 
-# FIXME: Implement context for impl class.
+
+# Context for implementation classes
+
+def dictionary_impl_context(dictionary, interfaces_info):
+    includes.clear()
+    header_includes = set(['platform/heap/Handle.h'])
+    return {
+        'header_includes': header_includes,
+        'cpp_class': v8_utilities.cpp_name(dictionary),
+        'members': [member_impl_context(member, interfaces_info,
+                                        header_includes)
+                    for member in dictionary.members],
+    }
+
+
+def member_impl_context(member, interfaces_info, header_includes):
+    idl_type = member.idl_type
+
+    def rvalue_cpp_type():
+        cpp_rvalue_type = idl_type.cpp_type_args(used_as_rvalue_type=True)
+        if (idl_type.native_array_element_type or idl_type.is_string_type):
+            return 'const %s&' % cpp_rvalue_type

[haraken, 2014/07/29 11:09:19]

I'm not quite sure why we need this special-casing. We might want to remove it
in a follow-up if possible.

[bashi, 2014/07/29 11:51:21]

Sorry, this should be in cpp_type(); This is a kind of leftover when I tried to
sequence<sequence<T>> workable. I got Vector<const Vector&<T> >. Since we don't
support sequence<sequence<T>>, this special casing should be gone. Will do
before landing.

[bashi, 2014/07/29 23:59:49]

Done. As a side effect, setter functions in impl classes takes "String", not
"const String&". I think this is ok because copying String isn't so costly and
we are already using it in argument_declarations_for_private_script(). We can
make "String" to "const String&", if we want to.

[haraken, 2014/07/30 00:00:56]

This would be fine.

+        return cpp_rvalue_type
+
+    def getter_expression():
+        if idl_type.impl_should_use_nullable_container:
+            return 'm_%s.get()' % member.name
+        return 'm_%s' % member.name
+
+    def has_method_expression():
+        if (idl_type.impl_should_use_nullable_container or
+            idl_type.is_string_type):
+            return '!m_%s.isNull()' % member.name
+        else:
+            return 'm_%s' % member.name
+
+    def member_cpp_type():
+        member_cpp_type = idl_type.cpp_type_args(used_in_cpp_sequence=True)
+        if idl_type.impl_should_use_nullable_container:
+            return v8_types.cpp_template_type('Nullable', member_cpp_type)
+        return member_cpp_type
+
+    header_includes.update(idl_type.impl_includes_for_type(interfaces_info))
+    return {
+        'getter_expression': getter_expression(),
+        'has_method_expression': has_method_expression(),
+        'has_method_name': has_method_name_for_dictionary_member(member),
+        'is_traceable': (idl_type.is_garbage_collected or
+                         idl_type.is_will_be_garbage_collected),
+        'member_cpp_type': member_cpp_type(),
+        'name': member.name,
+        'rvalue_cpp_type': rvalue_cpp_type(),
+        'setter_name': setter_name_for_dictionary_member(member),
+    }