Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 420613004: Remove the initial space in the QUIC user agent ID. (Closed)

Created:
6 years, 4 months ago by wtc
Modified:
6 years, 4 months ago
CC:
chromium-reviews, avd
Project:
chromium
Visibility:
Public.

Description

Remove the initial space in the QUIC user agent ID. If chrome::VersionInfo::GetVersionStringModifier() returns an empty string (which is the case for the Stable channel and any unofficial builds), don't append a space. R=rtenneti@chromium.org,thestig@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285529

Patch Set 1 #

Patch Set 2 : Use push_back to append a character. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/io_thread.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
6 years, 4 months ago (2014-07-24 23:36:04 UTC) #1
ramant (doing other things)
lgtm Thanks for doing this.
6 years, 4 months ago (2014-07-24 23:37:39 UTC) #2
wtc
Lei: please review. Thanks.
6 years, 4 months ago (2014-07-24 23:43:46 UTC) #3
Lei Zhang
lgtm
6 years, 4 months ago (2014-07-24 23:47:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/420613004/20001
6 years, 4 months ago (2014-07-24 23:50:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 08:31:58 UTC) #6
Message was sent while issue was closed.
Change committed as 285529

Powered by Google App Engine
This is Rietveld 408576698