chrome/browser/io_thread.cc - Issue 420613004: Remove the initial space in the QUIC user agent ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/io_thread.cc

Issue 420613004: Remove the initial space in the QUIC user agent ID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use push_back to append a character. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/io_thread.cc

diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc

index a97a732defdbac634cb85249a145f97c75aaafe9..c8fe59e5dc3a3a6ceb6f3a7079fe948aafd025af 100644

--- a/chrome/browser/io_thread.cc

+++ b/chrome/browser/io_thread.cc

@@ -1172,7 +1172,8 @@ void IOThread::ConfigureQuicGlobals(

std::string quic_user_agent_id =

chrome::VersionInfo::GetVersionStringModifier();

- quic_user_agent_id.append(1, ' ');

+ if (!quic_user_agent_id.empty())

+ quic_user_agent_id.push_back(' ');

chrome::VersionInfo version_info;

quic_user_agent_id.append(version_info.ProductNameAndVersionForUserAgent());

globals->quic_user_agent_id.set(quic_user_agent_id);

« no previous file with comments | « no previous file | no next file » | no next file with comments »