Declarative content scripts: Browser-side: per-extension shared memory regions (lazily loaded)

chrome/browser/extensions/shared_user_script_master.cc

Index: chrome/browser/extensions/shared_user_script_master.cc
diff --git a/chrome/browser/extensions/shared_user_script_master.cc b/chrome/browser/extensions/shared_user_script_master.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d80adac20d41ba5db19ab8de14051fb413fbbd38
--- /dev/null
+++ b/chrome/browser/extensions/shared_user_script_master.cc
@@ -0,0 +1,63 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/shared_user_script_master.h"
+
+#include "chrome/browser/extensions/extension_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"
+#include "extensions/browser/extension_registry.h"
+
+namespace extensions {
+
+SharedUserScriptMaster::SharedUserScriptMaster(Profile* profile)
+    : loader_(profile,
+              "" /* owner_extension_id */,

[Devlin, 2014/08/05 21:47:27]

nit: slightly prefer std::string()

[Mark Dittmer, 2014/08/06 15:32:25]

Done.

+              true /* listen_for_extension_system_loaded */),
+      profile_(profile),
+      extension_registry_observer_(this) {
+  extension_registry_observer_.Add(ExtensionRegistry::Get(profile_));
+}
+
+SharedUserScriptMaster::~SharedUserScriptMaster() {
+}
+
+void SharedUserScriptMaster::OnExtensionLoaded(
+    content::BrowserContext* browser_context,
+    const Extension* extension) {
+  loader_.AddScripts(GetScriptsMetadata(extension));
+}
+
+void SharedUserScriptMaster::OnExtensionUnloaded(
+    content::BrowserContext* browser_context,
+    const Extension* extension,
+    UnloadedExtensionInfo::Reason reason) {
+  loader_.RemoveScripts(GetScriptsMetadata(extension));

[Devlin, 2014/08/05 21:47:27]

Shouldn't we remove the scripts from scripts_metadata_ here?

[Mark Dittmer, 2014/08/06 15:32:25]

Yes! Good catch. Otherwise, we won't reload potentially changed manifest data
when an extension is unloaded, then loaded.

+}
+
+const std::set<UserScript>& SharedUserScriptMaster::GetScriptsMetadata(
+    const Extension* extension) {
+  const ExtensionId& id = extension->id();
+  std::map<ExtensionId, std::set<UserScript> >::const_iterator iter =
+      scripts_metadata_.find(id);
+  if (iter != scripts_metadata_.end())
+    return iter->second;
+
+  scripts_metadata_[id] = std::set<UserScript>();
+  bool incognito_enabled = util::IsIncognitoEnabled(id, profile_);
+  const UserScriptList& fetched_scripts =
+      ContentScriptsInfo::GetContentScripts(extension);
+  std::set<UserScript>& stored_scripts = scripts_metadata_[id];
+  for (UserScriptList::const_iterator it = fetched_scripts.begin();
+       it != fetched_scripts.end();
+       ++it) {
+    UserScript script = *it;
+    script.set_incognito_enabled(incognito_enabled);
+    stored_scripts.insert(script);
+  }
+
+  return stored_scripts;
+}
+
+}  // namespace extensions