Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/browser/extensions/shared_user_script_master.cc

Issue 420543002: Declarative content scripts: Browser-side: per-extension shared memory regions (lazily loaded) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement changes from code review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/extensions/shared_user_script_master.h"
6
7 #include "chrome/browser/extensions/extension_util.h"
8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"
10 #include "extensions/browser/extension_registry.h"
11
12 namespace extensions {
13
14 SharedUserScriptMaster::SharedUserScriptMaster(Profile* profile)
15 : loader_(profile,
16 "" /* owner_extension_id */,
Devlin 2014/08/05 21:47:27 nit: slightly prefer std::string()
Mark Dittmer 2014/08/06 15:32:25 Done.
17 true /* listen_for_extension_system_loaded */),
18 profile_(profile),
19 extension_registry_observer_(this) {
20 extension_registry_observer_.Add(ExtensionRegistry::Get(profile_));
21 }
22
23 SharedUserScriptMaster::~SharedUserScriptMaster() {
24 }
25
26 void SharedUserScriptMaster::OnExtensionLoaded(
27 content::BrowserContext* browser_context,
28 const Extension* extension) {
29 loader_.AddScripts(GetScriptsMetadata(extension));
30 }
31
32 void SharedUserScriptMaster::OnExtensionUnloaded(
33 content::BrowserContext* browser_context,
34 const Extension* extension,
35 UnloadedExtensionInfo::Reason reason) {
36 loader_.RemoveScripts(GetScriptsMetadata(extension));
Devlin 2014/08/05 21:47:27 Shouldn't we remove the scripts from scripts_metad
Mark Dittmer 2014/08/06 15:32:25 Yes! Good catch. Otherwise, we won't reload potent
37 }
38
39 const std::set<UserScript>& SharedUserScriptMaster::GetScriptsMetadata(
40 const Extension* extension) {
41 const ExtensionId& id = extension->id();
42 std::map<ExtensionId, std::set<UserScript> >::const_iterator iter =
43 scripts_metadata_.find(id);
44 if (iter != scripts_metadata_.end())
45 return iter->second;
46
47 scripts_metadata_[id] = std::set<UserScript>();
48 bool incognito_enabled = util::IsIncognitoEnabled(id, profile_);
49 const UserScriptList& fetched_scripts =
50 ContentScriptsInfo::GetContentScripts(extension);
51 std::set<UserScript>& stored_scripts = scripts_metadata_[id];
52 for (UserScriptList::const_iterator it = fetched_scripts.begin();
53 it != fetched_scripts.end();
54 ++it) {
55 UserScript script = *it;
56 script.set_incognito_enabled(incognito_enabled);
57 stored_scripts.insert(script);
58 }
59
60 return stored_scripts;
61 }
62
63 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698