Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4651)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 420533002: zoom bubble: Close if anchor is clicked while bubble is showing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
index 98d4a9297e0de6cc204eb6636ef6fa07297151e7..99ff92d16bbebb8d8ef8764809c7a729185bb41e 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
@@ -18,6 +18,7 @@ class BubbleIconView : public views::ImageView {
EXECUTE_SOURCE_GESTURE,
};
+ BubbleIconView();
msw 2014/10/24 00:00:55 Remove this, ZoomBubbleView can just pass BubbleIc
Dan Beam 2014/10/24 00:26:19 Done.
explicit BubbleIconView(CommandUpdater* command_updater, int command_id);
virtual ~BubbleIconView();
msw 2014/10/24 00:00:55 optional nit: virtual -> override here and below.
Dan Beam 2014/10/24 00:26:19 Done.
@@ -39,6 +40,10 @@ class BubbleIconView : public views::ImageView {
virtual void OnGestureEvent(ui::GestureEvent* event) override;
private:
+ // Executes the given |command_id_| with |command_updater_| if specified when
msw 2014/10/24 00:00:55 optional nit: one-liner "// Calls OnExecuting and
Dan Beam 2014/10/24 00:26:19 Done.
+ // constructed.
+ void ExecuteCommand();
+
// The CommandUpdater for the Browser object that owns the location bar.
CommandUpdater* command_updater_;

Powered by Google App Engine
This is Rietveld 408576698