zoom bubble: Close if anchor is clicked while bubble is showing.

chrome/browser/ui/views/location_bar/bubble_icon_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_
 
 #include "ui/views/controls/image_view.h"
 
 class CommandUpdater;
 
 // Represents an icon on the omnibox that shows a bubble when clicked.
 class BubbleIconView : public views::ImageView {
  protected:
   enum ExecuteSource {
     EXECUTE_SOURCE_MOUSE,
     EXECUTE_SOURCE_KEYBOARD,
     EXECUTE_SOURCE_GESTURE,
   };
 
+  BubbleIconView();

[msw, 2014/10/24 00:00:55]

Remove this, ZoomBubbleView can just pass BubbleIconView(nullptr, 0).
(bonus points if you wanted to actually hook up IDC_ZOOM_MENU)

[Dan Beam, 2014/10/24 00:26:19]

Done.
i'm hesitant to do this as it's already used in the flapjacks menu

   explicit BubbleIconView(CommandUpdater* command_updater, int command_id);
   virtual ~BubbleIconView();

[msw, 2014/10/24 00:00:55]

optional nit: virtual -> override here and below.

[Dan Beam, 2014/10/24 00:26:19]

Done.

 
   // Returns true if a related bubble is showing.
   virtual bool IsBubbleShowing() const = 0;
 
   // Invoked prior to executing the command.
   virtual void OnExecuting(ExecuteSource execute_source) = 0;
 
   // views::ImageView:
   virtual void GetAccessibleState(ui::AXViewState* state) override;
   virtual bool GetTooltipText(const gfx::Point& p, base::string16* tooltip)
       const override;
   virtual bool OnMousePressed(const ui::MouseEvent& event) override;
   virtual void OnMouseReleased(const ui::MouseEvent& event) override;
   virtual bool OnKeyPressed(const ui::KeyEvent& event) override;
 
   // ui::EventHandler:
   virtual void OnGestureEvent(ui::GestureEvent* event) override;
 
  private:
+  // Executes the given |command_id_| with |command_updater_| if specified when

[msw, 2014/10/24 00:00:55]

optional nit: one-liner "// Calls OnExecuting and runs |command_id_| with a
valid |command_updater_|."

[Dan Beam, 2014/10/24 00:26:19]

Done.

+  // constructed.
+  void ExecuteCommand();
+
   // The CommandUpdater for the Browser object that owns the location bar.
   CommandUpdater* command_updater_;
 
   // The command ID executed when the user clicks this icon.
   const int command_id_;
 
   // This is used to check if the bookmark bubble was showing during the mouse
   // pressed event. If this is true then the mouse released event is ignored to
   // prevent the bubble from reshowing.
   bool suppress_mouse_released_action_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleIconView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_H_