Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/component_updater/test/component_patcher_unittest.cc

Issue 420503002: Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/test/component_patcher_unittest.cc
diff --git a/chrome/browser/component_updater/test/component_patcher_unittest.cc b/chrome/browser/component_updater/test/component_patcher_unittest.cc
index d220d9d28575c4573ab223f5dd59c1988ca2b1b1..ca1b93b016be4b089ef5b951946219b9651aabc6 100644
--- a/chrome/browser/component_updater/test/component_patcher_unittest.cc
+++ b/chrome/browser/component_updater/test/component_patcher_unittest.cc
@@ -92,7 +92,6 @@ TEST_F(ComponentPatcherOperationTest, CheckCreateOperation) {
input_dir_.path(),
unpack_dir_.path(),
NULL,
- true,
base::Bind(&TestCallback::Set, base::Unretained(&callback)),
task_runner_);
base::RunLoop().RunUntilIdle();
@@ -123,7 +122,6 @@ TEST_F(ComponentPatcherOperationTest, CheckCopyOperation) {
input_dir_.path(),
unpack_dir_.path(),
installer_.get(),
- true,
base::Bind(&TestCallback::Set, base::Unretained(&callback)),
task_runner_);
base::RunLoop().RunUntilIdle();
@@ -153,12 +151,13 @@ TEST_F(ComponentPatcherOperationTest, CheckCourgetteOperation) {
command_args->SetString("patch", "binary_courgette_patch.bin");
TestCallback callback;
- scoped_refptr<DeltaUpdateOp> op = CreateDeltaUpdateOp("courgette");
+ scoped_ptr<DeltaUpdateOpFactory> factory(
+ CreateInProcessDeltaUpdateOpFactory());
+ scoped_refptr<DeltaUpdateOp> op = factory->CreateDeltaUpdateOp("courgette");
op->Run(command_args.get(),
input_dir_.path(),
unpack_dir_.path(),
installer_.get(),
- true,
base::Bind(&TestCallback::Set, base::Unretained(&callback)),
task_runner_);
base::RunLoop().RunUntilIdle();
@@ -188,12 +187,13 @@ TEST_F(ComponentPatcherOperationTest, CheckBsdiffOperation) {
command_args->SetString("patch", "binary_bsdiff_patch.bin");
TestCallback callback;
- scoped_refptr<DeltaUpdateOp> op = CreateDeltaUpdateOp("bsdiff");
+ scoped_ptr<DeltaUpdateOpFactory> factory(
+ CreateInProcessDeltaUpdateOpFactory());
+ scoped_refptr<DeltaUpdateOp> op = factory->CreateDeltaUpdateOp("bsdiff");
op->Run(command_args.get(),
input_dir_.path(),
unpack_dir_.path(),
installer_.get(),
- true,
base::Bind(&TestCallback::Set, base::Unretained(&callback)),
task_runner_);
base::RunLoop().RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698