Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version.

chrome/browser/component_updater/component_patcher.h

Index: chrome/browser/component_updater/component_patcher.h
diff --git a/chrome/browser/component_updater/component_patcher.h b/chrome/browser/component_updater/component_patcher.h
index f96e1565683533e4d641cb97a07dc4c4561577b0..7a5081a314c9f83b44ea72066bd23ebe1de22e93 100644
--- a/chrome/browser/component_updater/component_patcher.h
+++ b/chrome/browser/component_updater/component_patcher.h
@@ -40,6 +40,7 @@ namespace component_updater {
 
 class ComponentInstaller;
 class DeltaUpdateOp;
+class DeltaUpdateOpFactory;
 
 // The type of a patch file.
 enum PatchType {
@@ -59,7 +60,7 @@ class ComponentPatcher : public base::RefCountedThreadSafe<ComponentPatcher> {
   ComponentPatcher(const base::FilePath& input_dir,
                    const base::FilePath& unpack_dir,
                    ComponentInstaller* installer,
-                   bool in_process,
+                   DeltaUpdateOpFactory* delta_update_op_factory,

[blundell, 2014/07/25 07:40:42]

If this object takes ownership of the factory, it should be passed in as a
scoped_ptr.

[tommycli, 2014/07/25 18:08:47]

I changed all the usages of this class to use scoped_ptr

                    scoped_refptr<base::SequencedTaskRunner> task_runner);
 
   // Starts patching files. This member function returns immediately, after
@@ -84,7 +85,7 @@ class ComponentPatcher : public base::RefCountedThreadSafe<ComponentPatcher> {
   const base::FilePath input_dir_;
   const base::FilePath unpack_dir_;
   ComponentInstaller* const installer_;
-  const bool in_process_;
+  scoped_ptr<DeltaUpdateOpFactory> delta_update_op_factory_;
   ComponentUnpacker::Callback callback_;
   scoped_ptr<base::ListValue> commands_;
   base::ValueVector::const_iterator next_command_;