chrome/browser/component_updater/component_unpacker.h - Issue 420503002: Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_unpacker.h

Issue 420503002: Componentize component_updater: Decouple in-process DeltaUpdateOp from out-of-process version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/component_patcher.h ('K') | « chrome/browser/component_updater/component_patcher_operation_out_of_process.cc ('k') | chrome/browser/component_updater/component_unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/component_unpacker.h

diff --git a/chrome/browser/component_updater/component_unpacker.h b/chrome/browser/component_updater/component_unpacker.h

index ffd69dd9c4adf21c1fa16a385dfdeb3c5d19207f..309a9e4d2965291fb7d0bf7a8d947c7790eb44e4 100644

--- a/chrome/browser/component_updater/component_unpacker.h

+++ b/chrome/browser/component_updater/component_unpacker.h

@@ -20,6 +20,7 @@ namespace component_updater {

class ComponentInstaller;

class ComponentPatcher;

+class DeltaUpdateOpFactory;

// Deserializes the CRX manifest. The top level must be a dictionary.

scoped_ptr<base::DictionaryValue> ReadManifest(

@@ -97,7 +98,7 @@ class ComponentUnpacker : public base::RefCountedThreadSafe<ComponentUnpacker> {

const base::FilePath& path,

const std::string& fingerprint,

ComponentInstaller* installer,

- bool in_process,

+ DeltaUpdateOpFactory* delta_update_op_factory,

scoped_refptr<base::SequencedTaskRunner> task_runner);

// Begins the actual unpacking of the files. May invoke a patcher if the

@@ -147,7 +148,7 @@ class ComponentUnpacker : public base::RefCountedThreadSafe<ComponentUnpacker> {

scoped_refptr<ComponentPatcher> patcher_;

ComponentInstaller* installer_;

Callback callback_;

- const bool in_process_;

+ scoped_ptr<DeltaUpdateOpFactory> delta_update_op_factory_;

Error error_;

int extended_error_;

scoped_refptr<base::SequencedTaskRunner> task_runner_;