Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 420443003: GN foreach should mark the list identifier as used. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

GN foreach should mark the list identifier as used. Previously an identifier used as the list in a feoreach statement would not count as "using" the identifier, which would give unused variable errors. Added a unit test. Checks for unused identifiers in component(). Previously these were not checked. This checking turned up a misspelling in the cc build. Added a unit test. Fixes for the ozone media build (turned up when testing). R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285367

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -24 lines) Patch
M cc/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 chunks +27 lines, -22 lines 0 comments Download
M tools/gn/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/function_foreach.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_foreach_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/gn/functions_target.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tools/gn/functions_target_unittest.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-24 18:06:31 UTC) #1
Dirk Pranke
lgtm (though I'm not scottmg)
6 years, 5 months ago (2014-07-24 18:19:06 UTC) #2
brettw
6 years, 5 months ago (2014-07-24 21:02:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r285367.

Powered by Google App Engine
This is Rietveld 408576698