tools/gn/function_foreach.cc - Issue 420443003: GN foreach should mark the list identifier as used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_foreach.cc

Issue 420443003: GN foreach should mark the list identifier as used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/function_foreach.cc

diff --git a/tools/gn/function_foreach.cc b/tools/gn/function_foreach.cc

index 40f389234cf6a4bbf95f0d44f1fc210fb56e9174..06a2dc17c156abac86ddb983defe7e88f2683d78 100644

--- a/tools/gn/function_foreach.cc

+++ b/tools/gn/function_foreach.cc

@@ -70,7 +70,7 @@ Value RunForEach(Scope* scope,

const Value* list_value = NULL;

const IdentifierNode* list_identifier = args_vector[1]->AsIdentifier();

if (list_identifier) {

- list_value = scope->GetValue(list_identifier->value().value());

+ list_value = scope->GetValue(list_identifier->value().value(), true);

if (!list_value) {

*err = Err(args_vector[1], "Undefined identifier.");

return Value();

« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/function_foreach_unittest.cc » ('j') | no next file with comments »